From: Tyler Hicks <tyhicks@canonical.com>
To: Jeff Layton <jlayton@poochiereds.net>
Cc: ecryptfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ecryptfs: remove unnecessary i_version bump
Date: Thu, 2 Nov 2017 17:43:48 -0500 [thread overview]
Message-ID: <5394f39a-2ae4-0e42-d2a0-bac52fc12352@canonical.com> (raw)
In-Reply-To: <1509375810.5412.22.camel@poochiereds.net>
[-- Attachment #1.1: Type: text/plain, Size: 1365 bytes --]
On 10/30/2017 10:03 AM, Jeff Layton wrote:
> On Mon, 2017-10-30 at 11:01 -0400, Jeff Layton wrote:
>> From: Jeff Layton <jlayton@redhat.com>
>>
>> There is no need to bump the i_version counter here, as ecryptfs does
>> not set the MS_I_VERSION flag, and doesn't use it internally. It also
>
> My apologies, I've been sitting on this patch for a while now. That
> should be changed to the SB_I_VERSION flag. Tyler, do you mind fixing
> that up before merge, or would you like me to resend?
That's no problem. Thanks for the patch! It looks good to me and I'll
take it through my tree.
Tyler
>
>> only bumps it when the inode is instantiated, which doesn't make much
>> sense.
>>
>> Signed-off-by: Jeff Layton <jlayton@redhat.com>
>> ---
>> fs/ecryptfs/inode.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
>> index efc2db42d175..b59b083379ea 100644
>> --- a/fs/ecryptfs/inode.c
>> +++ b/fs/ecryptfs/inode.c
>> @@ -64,7 +64,6 @@ static int ecryptfs_inode_set(struct inode *inode, void *opaque)
>> /* i_size will be overwritten for encrypted regular files */
>> fsstack_copy_inode_size(inode, lower_inode);
>> inode->i_ino = lower_inode->i_ino;
>> - inode->i_version++;
>> inode->i_mapping->a_ops = &ecryptfs_aops;
>>
>> if (S_ISLNK(inode->i_mode))
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2017-11-02 22:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 15:01 [PATCH] ecryptfs: remove unnecessary i_version bump Jeff Layton
2017-10-30 15:03 ` Jeff Layton
2017-11-02 22:43 ` Tyler Hicks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5394f39a-2ae4-0e42-d2a0-bac52fc12352@canonical.com \
--to=tyhicks@canonical.com \
--cc=ecryptfs@vger.kernel.org \
--cc=jlayton@poochiereds.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).