From: Tyler Hicks <tyhicks@canonical.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>, viro@zeniv.linux.org.uk
Cc: ecryptfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] eCryptfs: constify attribute_group structures.
Date: Fri, 13 Oct 2017 21:27:06 -0400 [thread overview]
Message-ID: <654de3f9-ad17-983b-43e9-8556ebaf500b@canonical.com> (raw)
In-Reply-To: <eea99b6294d950736f63fd6d88ab129435233bd5.1498814950.git.arvind.yadav.cs@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1220 bytes --]
Hi Arvind - My apologies for the extremely slow review.
On 06/30/2017 05:33 AM, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 6122 636 24 6782 1a7e fs/ecryptfs/main.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 6186 604 24 6814 1a9e fs/ecryptfs/main.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
This patch looks good. I'll get it queued up for 4.15.
Tyler
> ---
> fs/ecryptfs/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c
> index 9014479..eea4c0f 100644
> --- a/fs/ecryptfs/main.c
> +++ b/fs/ecryptfs/main.c
> @@ -782,7 +782,7 @@ static ssize_t version_show(struct kobject *kobj,
> NULL,
> };
>
> -static struct attribute_group attr_group = {
> +static const struct attribute_group attr_group = {
> .attrs = attributes,
> };
>
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2017-10-14 1:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 9:33 [PATCH] eCryptfs: constify attribute_group structures Arvind Yadav
2017-10-14 1:27 ` Tyler Hicks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=654de3f9-ad17-983b-43e9-8556ebaf500b@canonical.com \
--to=tyhicks@canonical.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=ecryptfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).