From: Andreas Gruenbacher <agruenba@redhat.com>
To: sedat.dilek@gmail.com
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Tyler Hicks <tyhicks@canonical.com>,
ecryptfs@vger.kernel.org, Miklos Szeredi <miklos@szeredi.hu>,
linux-unionfs@vger.kernel.org,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
linux-ima-devel@lists.sourceforge.net,
LSM <linux-security-module@vger.kernel.org>,
David Howells <dhowells@redhat.com>,
Serge Hallyn <serge.hallyn@canonical.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
Paul Moore <paul@paul-moore.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
Eric Paris <eparis@parisplace.org>,
Casey Schaufler <casey@schaufler-ca.com>,
Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>
Subject: Re: [PATCH v3 00/17] Xattr inode operation removal
Date: Mon, 30 May 2016 21:29:37 +0200 [thread overview]
Message-ID: <CAHc6FU5_ptUJG15k+c=5xcBa1CtNXzVk3pC7jT5iW_CU56tnFA@mail.gmail.com> (raw)
In-Reply-To: <CA+icZUWUkY7Rj6+K26tAffUtCbySLiCvyD+ZYvoPrJPQO1cO+w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 239 bytes --]
On Mon, May 30, 2016 at 8:51 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
> Which "trusted." line or lines shall I remove?
You can try something like the attached patch. Ovetall, the test case
doesn't seem very useful.
Thanks,
Andreas
[-- Attachment #2: ltp-xattr.patch --]
[-- Type: text/x-patch, Size: 1629 bytes --]
diff --git a/testcases/kernel/controllers/cgroup_xattr/cgroup_xattr.c b/testcases/kernel/controllers/cgroup_xattr/cgroup_xattr.c
index 492ddc7..a7c131f 100644
--- a/testcases/kernel/controllers/cgroup_xattr/cgroup_xattr.c
+++ b/testcases/kernel/controllers/cgroup_xattr/cgroup_xattr.c
@@ -64,9 +64,9 @@ struct tst_key {
/* only security.* & trusted.* are valid key names */
static struct tst_key tkeys[] = {
- { .name = "security.", .good = 1, },
+ { .name = "security.", .good = 0, }, /* see setup() */
{ .name = "trusted.test", .good = 1, },
- { .name = "trusted.", .good = 1, },
+ { .name = "trusted.", .good = 0, }, /* see setup() */
{ .name = "user.", .good = 0, },
{ .name = "system.", .good = 0, },
};
@@ -141,6 +141,8 @@ static void help(void)
void setup(int argc, char *argv[])
{
+ unsigned int i;
+
tst_parse_opts(argc, argv, options, help);
tst_require_root();
@@ -153,17 +155,11 @@ void setup(int argc, char *argv[])
"Test must be run with kernel 3.7 or newer");
}
- if (tst_kvercmp(3, 15, 0) >= 0) {
- /* In kernel v3.15 cgroup was converted to kernfs
- * that doesn't provide simple security namespace handlers.
- * Setting just 'security.' should return EOPNOTSUPP.
- */
- unsigned int i;
- for (i = 0; i < ARRAY_SIZE(tkeys); ++i) {
- if (!strcmp(tkeys[i].name, "security.")) {
- tkeys[i].good = 0;
- break;
- }
+ for (i = 0; i < ARRAY_SIZE(tkeys); ++i) {
+ if (!strcmp(tkeys[i].name, "security.")) {
+ tkeys[i].good = tst_kvercmp(3, 15, 0) < 0;
+ } else if (!strcmp(tkeys[i].name, "trusted.")) {
+ tkeys[i].good = tst_kvercmp(4, 5, 0) < 0;
}
}
prev parent reply other threads:[~2016-05-30 19:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 8:57 [PATCH v3 00/17] Xattr inode operation removal Andreas Gruenbacher
2016-05-30 8:57 ` [PATCH v3 01/17] xattr: Remove unnecessary NULL attribute name check Andreas Gruenbacher
2016-05-30 8:57 ` [PATCH v3 02/17] jffs2: Remove jffs2_{get,set,remove}xattr macros Andreas Gruenbacher
2016-05-30 8:57 ` [PATCH v3 03/17] hfs: Switch to generic xattr handlers Andreas Gruenbacher
2016-05-30 8:57 ` [PATCH v3 04/17] kernfs: " Andreas Gruenbacher
2016-05-30 8:57 ` [PATCH v3 05/17] sockfs: getxattr: Fail with -EOPNOTSUPP for invalid attribute names Andreas Gruenbacher
2016-05-30 8:57 ` [PATCH v3 06/17] sockfs: Get rid of getxattr iop Andreas Gruenbacher
2016-05-30 8:57 ` [PATCH v3 07/17] ecryptfs: Switch to generic xattr handlers Andreas Gruenbacher
2016-05-30 8:57 ` [PATCH v3 08/17] overlayfs: " Andreas Gruenbacher
2016-05-30 8:57 ` [PATCH v3 09/17] fuse: " Andreas Gruenbacher
2016-05-30 8:57 ` [PATCH v3 10/17] vfs: Move xattr_resolve_name to the front of fs/xattr.c Andreas Gruenbacher
2016-05-30 8:57 ` [PATCH v3 11/17] vfs: Add IOP_XATTR inode operations flag Andreas Gruenbacher
2016-05-30 8:57 ` [PATCH v3 12/17] vfs: Use IOP_XATTR flag for bad-inode handling Andreas Gruenbacher
2016-05-30 8:57 ` [PATCH v3 13/17] libfs: Use IOP_XATTR flag for empty directory handling Andreas Gruenbacher
2016-05-30 8:57 ` [PATCH v3 14/17] xattr: Add __vfs_{get,set,remove}xattr helpers Andreas Gruenbacher
2016-05-30 8:57 ` [PATCH v3 15/17] vfs: Check for the IOP_XATTR flag in listxattr Andreas Gruenbacher
2016-05-30 8:57 ` [PATCH v3 16/17] xattr: Stop calling {get,set,remove}xattr inode operations Andreas Gruenbacher
2016-05-30 8:57 ` [PATCH v3 17/17] vfs: Remove " Andreas Gruenbacher
[not found] ` <CA+icZUXGxsw-g1W8QzwuFx=8UTnxzQD9UsNEH2PHCGrqW=0xdA@mail.gmail.com>
2016-05-30 10:49 ` [PATCH v3 00/17] Xattr inode operation removal Andreas Gruenbacher
2016-05-30 12:56 ` Sedat Dilek
[not found] ` <CA+icZUWVdtqK4OcXhjVDbrqfXBO5-DpbB5nVpX+iTN_RBDH5Xw@mail.gmail.com>
2016-05-30 18:22 ` Andreas Gruenbacher
2016-05-30 18:51 ` Sedat Dilek
2016-05-30 19:29 ` Andreas Gruenbacher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHc6FU5_ptUJG15k+c=5xcBa1CtNXzVk3pC7jT5iW_CU56tnFA@mail.gmail.com' \
--to=agruenba@redhat.com \
--cc=andreas.dilger@intel.com \
--cc=casey@schaufler-ca.com \
--cc=dhowells@redhat.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=ecryptfs@vger.kernel.org \
--cc=eparis@parisplace.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ima-devel@lists.sourceforge.net \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=oleg.drokin@intel.com \
--cc=paul@paul-moore.com \
--cc=sds@tycho.nsa.gov \
--cc=sedat.dilek@gmail.com \
--cc=serge.hallyn@canonical.com \
--cc=tyhicks@canonical.com \
--cc=viro@zeniv.linux.org.uk \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).