From: Eric Biggers <ebiggers@kernel.org>
To: yang.yang29@zte.com.cn
Cc: code@tyhicks.com, ira.weiny@intel.com, fmdefrancesco@gmail.com,
ecryptfs@vger.kernel.org, linux-kernel@vger.kernel.org,
xu.panda@zte.com.cn
Subject: Re: [PATCH linux-next] ecryptfs: crypto: use strscpy() to instead of strncpy()
Date: Thu, 29 Dec 2022 12:51:52 -0800 [thread overview]
Message-ID: <Y6396PQlotOmKirR@sol.localdomain> (raw)
In-Reply-To: <202212280936545669762@zte.com.cn>
On Wed, Dec 28, 2022 at 09:36:54AM +0800, yang.yang29@zte.com.cn wrote:
> From: Xu Panda <xu.panda@zte.com.cn>
>
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL-terminated strings.
Unlike strncpy(), strscpy() does not initialize the full destination array, so
it is unsafe in some situations, such as initializing structures that are then
copied to userspace or to disk. Please include an actual explanation for why
this patch is correct.
- Eric
prev parent reply other threads:[~2022-12-29 20:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 1:36 [PATCH linux-next] ecryptfs: crypto: use strscpy() to instead of strncpy() yang.yang29
2022-12-29 20:51 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6396PQlotOmKirR@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=code@tyhicks.com \
--cc=ecryptfs@vger.kernel.org \
--cc=fmdefrancesco@gmail.com \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xu.panda@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).