From: James Prestwood <prestwoj@gmail.com>
To: Denis Kenzior <denkenz@gmail.com>, ell@lists.linux.dev
Subject: Re: [RFC 1/8] key: add l_key_search
Date: Tue, 22 Nov 2022 09:16:36 -0800 [thread overview]
Message-ID: <176cde43f3fe383fbb096eeb3b4f7be8b212a19f.camel@gmail.com> (raw)
In-Reply-To: <f4f33ae6-ba6f-e19a-89cb-6ba5c9a101f1@gmail.com>
On Tue, 2022-11-22 at 10:43 -0600, Denis Kenzior wrote:
> Hi James,
>
> On 11/18/22 15:16, James Prestwood wrote:
> > Search for a key by type, keyring name, and description. Returns
> > the
> > key ID or an error if not found.
> > ---
> > ell/ell.sym | 1 +
> > ell/key.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
> > ell/key.h | 3 +++
> > 3 files changed, 50 insertions(+)
> >
>
> <snip>
>
> > @@ -283,6 +303,32 @@ static bool setup_internal_keyring(void)
> > return true;
> > }
> >
> > +LIB_EXPORT int32_t l_key_search(enum l_key_type type, const char
> > *keyring,
>
> How likely are we to search some custom keyring? Wouldn't we
> generally be
> searching a user/default user session keyrings?
I was just leaning on the side of flexibility. I don't really care
either way but figured an extra argument was fine even if we end up
calling it with "user".
>
> > + const char *description)
> > +{
> > + long keyring_id;
> > + long key_id;
> > +
> > + if (unlikely((size_t)type >= L_ARRAY_SIZE(key_type_names)))
> > + return -EINVAL;
> > +
> > + if (unlikely(!keyring || !description))
> > + return -EINVAL;
> > +
> > + /* Find the ID of the keyring */
> > + keyring_id = kernel_key_request("keyring", keyring);
> > + if (keyring_id < 0)
> > + return -ENOENT;
> > +
> > + /* Search for the key by type/description */
> > + key_id = kernel_key_search(keyring_id,
> > key_type_names[type],
> > + description);
> > + if (key_id < 0)
> > + return -ENOENT;
> > +
> > + return key_id;
> > +}
> > +
> > LIB_EXPORT struct l_key *l_key_new(enum l_key_type type, const
> > void *payload,
> > size_t payload_length)
> > {
>
> Regards,
> -Denis
next prev parent reply other threads:[~2022-11-22 17:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 21:16 [RFC 0/8] Crypto operations by key ID James Prestwood
2022-11-18 21:16 ` [RFC 1/8] key: add l_key_search James Prestwood
2022-11-22 16:43 ` Denis Kenzior
2022-11-22 17:16 ` James Prestwood [this message]
2022-11-22 17:09 ` Denis Kenzior
2022-11-22 18:34 ` James Prestwood
2022-11-18 21:16 ` [RFC 2/8] unit: add key search test James Prestwood
2022-11-18 21:16 ` [RFC 3/8] checksum: commonize checksum creation James Prestwood
2022-11-22 16:46 ` Denis Kenzior
2022-11-18 21:16 ` [RFC 4/8] checksum: add l_checksum_new_hmac_from_key_id James Prestwood
2022-11-22 16:53 ` Denis Kenzior
2022-11-18 21:16 ` [RFC 5/8] cert-crypto: refactor l_cert_pkcs5_pbkdf2 James Prestwood
2022-11-22 17:00 ` Denis Kenzior
2022-11-18 21:16 ` [RFC 6/8] cert: add l_cert_pkcs5_pbkdf2_from_key_id James Prestwood
2022-11-22 17:03 ` Denis Kenzior
2022-11-18 21:16 ` [RFC 7/8] cert: add explicit length to l_cert_pkcs5_pbkdf2 James Prestwood
2022-11-18 21:16 ` [RFC 8/8] unit: update test-pbkdf2 with API change James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176cde43f3fe383fbb096eeb3b4f7be8b212a19f.camel@gmail.com \
--to=prestwoj@gmail.com \
--cc=denkenz@gmail.com \
--cc=ell@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).