From: Andrew Zaborowski <andrew.zaborowski at intel.com>
To: ell at lists.01.org
Subject: [PATCH 3/3] tls: Fix state check on Client Hello
Date: Thu, 26 May 2022 17:56:57 +0200 [thread overview]
Message-ID: <20220526155657.63641-3-andrew.zaborowski@intel.com> (raw)
In-Reply-To: 20220526155657.63641-1-andrew.zaborowski@intel.com
[-- Attachment #1: Type: text/plain, Size: 700 bytes --]
A Client Hello message is allowed in the WAIT_HELLO and DONE states,
apparently this check had a typo.
---
ell/tls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ell/tls.c b/ell/tls.c
index fa00075..b2f7411 100644
--- a/ell/tls.c
+++ b/ell/tls.c
@@ -2740,7 +2740,7 @@ bool tls_handle_message(struct l_tls *tls, const uint8_t *message,
/* Start hashing the handshake contents on first message */
if (tls->server && message[0] == TLS_CLIENT_HELLO &&
(tls->state == TLS_HANDSHAKE_WAIT_HELLO ||
- tls->state != TLS_HANDSHAKE_DONE))
+ tls->state == TLS_HANDSHAKE_DONE))
if (!tls_init_handshake_hash(tls))
return false;
--
2.32.0
reply other threads:[~2022-05-26 15:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220526155657.63641-3-andrew.zaborowski@intel.com \
--to=ell@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).