From: Denis Kenzior <denkenz@gmail.com>
To: James Prestwood <prestwoj@gmail.com>, ell@lists.linux.dev
Subject: Re: [RFC 4/8] checksum: add l_checksum_new_hmac_from_key_id
Date: Tue, 22 Nov 2022 10:53:03 -0600 [thread overview]
Message-ID: <325d9738-a755-2a54-1e78-7792e818a1cf@gmail.com> (raw)
In-Reply-To: <20221118211624.19298-5-prestwoj@gmail.com>
Hi James,
On 11/18/22 15:16, James Prestwood wrote:
> Same as l_checksum_new_hmac but uses a key ID rather than a
> key directly.
> ---
> ell/checksum.c | 17 +++++++++++++++++
> ell/checksum.h | 2 ++
> ell/ell.sym | 1 +
> 3 files changed, 20 insertions(+)
>
<snip>
> @@ -213,6 +217,19 @@ LIB_EXPORT struct l_checksum *l_checksum_new_hmac(enum l_checksum_type type,
> &checksum_hmac_algs[type]);
> }
>
> +struct l_checksum *l_checksum_new_hmac_from_key_id(enum l_checksum_type type,
> + int32_t key_id)
Missing LIB_EXPORT?
> +{
> + if (!is_valid_index(checksum_hmac_algs, type) ||
> + !checksum_hmac_algs[type].name)
> + return NULL;
> +
> + return checksum_new_common(checksum_hmac_algs[type].name,
> + ALG_SET_KEY_BY_KEY_SERIAL,
> + &key_id, sizeof(key_id),
> + &checksum_hmac_algs[type]);
> +}
> +
> /**
> * l_checksum_clone:
> * @checksum: parent checksum object
Regards,
-Denis
next prev parent reply other threads:[~2022-11-22 17:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 21:16 [RFC 0/8] Crypto operations by key ID James Prestwood
2022-11-18 21:16 ` [RFC 1/8] key: add l_key_search James Prestwood
2022-11-22 16:43 ` Denis Kenzior
2022-11-22 17:16 ` James Prestwood
2022-11-22 17:09 ` Denis Kenzior
2022-11-22 18:34 ` James Prestwood
2022-11-18 21:16 ` [RFC 2/8] unit: add key search test James Prestwood
2022-11-18 21:16 ` [RFC 3/8] checksum: commonize checksum creation James Prestwood
2022-11-22 16:46 ` Denis Kenzior
2022-11-18 21:16 ` [RFC 4/8] checksum: add l_checksum_new_hmac_from_key_id James Prestwood
2022-11-22 16:53 ` Denis Kenzior [this message]
2022-11-18 21:16 ` [RFC 5/8] cert-crypto: refactor l_cert_pkcs5_pbkdf2 James Prestwood
2022-11-22 17:00 ` Denis Kenzior
2022-11-18 21:16 ` [RFC 6/8] cert: add l_cert_pkcs5_pbkdf2_from_key_id James Prestwood
2022-11-22 17:03 ` Denis Kenzior
2022-11-18 21:16 ` [RFC 7/8] cert: add explicit length to l_cert_pkcs5_pbkdf2 James Prestwood
2022-11-18 21:16 ` [RFC 8/8] unit: update test-pbkdf2 with API change James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=325d9738-a755-2a54-1e78-7792e818a1cf@gmail.com \
--to=denkenz@gmail.com \
--cc=ell@lists.linux.dev \
--cc=prestwoj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).