From: Denis Kenzior <denkenz at gmail.com>
To: ell at lists.01.org
Subject: Re: [PATCH] dhcp: Use bound_time for retransmission timers
Date: Fri, 13 May 2022 09:30:49 -0500 [thread overview]
Message-ID: <75266a95-e0b2-e375-3175-d45e605ed7c6@gmail.com> (raw)
In-Reply-To: CACsRnHW6LNDMxhrZB-_7JAH3h3Q54D9vUqf-YJhfEg4FgBC-gA@mail.gmail.com
[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]
Hi Michael,
On 5/13/22 08:53, Michael Johnson wrote:
> Hi Denis,
>
> I've been running this patch for the day and I don't think it's
> actually fixed the retry. I have set a low lease time and then block
> the DHCP server for the ACK and I can see that the retry still doesn't
> happen.
I suspect it does fix one bug, but not another... I'm not near my test box
right now, so debugging this is a bit painful.
Could you debug-print the 'next_timeout' we calculate in
dhcp_client_t1_expired() here:
next_timeout = dhcp_rebind_renew_retry_time(client->start_t,
client->lease->t2);
And also put in
L_WARN_ON(!client->timeout_resend);
after the timeout_resend timer is created?
From your 'other' bug report yesterday, we calculate the t1 timer correctly,
but the timer still doesn't fire.
It almost feels like the timers are just not being created. Is there anything
suspicious in the kernel logs?
Regards,
-Denis
next reply other threads:[~2022-05-13 14:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 14:30 Denis Kenzior [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-05-18 16:21 [PATCH] dhcp: Use bound_time for retransmission timers Denis Kenzior
2022-05-13 17:10 Michael Johnson
2022-05-13 16:23 Denis Kenzior
2022-05-13 15:40 Michael Johnson
2022-05-13 15:31 Michael Johnson
2022-05-13 13:53 Michael Johnson
2022-05-11 17:28 Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75266a95-e0b2-e375-3175-d45e605ed7c6@gmail.com \
--to=ell@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).