From: Andrew Zaborowski <andrew.zaborowski at intel.com>
To: ell at lists.01.org
Subject: Re: [PATCH 07/17] netconfig: Use an internal rtnl socket for l_netconfig_apply_rtnl
Date: Thu, 19 May 2022 13:52:47 +0200 [thread overview]
Message-ID: <CAOq732JFUWwpJpg7BNAWH4JT5CnN-EHNLD_7eDERYEqaRwEqmQ@mail.gmail.com> (raw)
In-Reply-To: 378dbbda-7453-9a67-db2f-e098ba159388@gmail.com
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
Hi Denis,
On Wed, 18 May 2022 at 20:58, Denis Kenzior <denkenz(a)gmail.com> wrote:
> On 5/13/22 17:47, Andrew Zaborowski wrote:
> > LIB_EXPORT struct l_netconfig *l_netconfig_new(uint32_t ifindex)
> > {
> > struct l_netconfig *nc;
> > + struct l_netlink *rtnl = l_netlink_new(NETLINK_ROUTE);
> > +
> > + if (!rtnl)
> > + return NULL;
>
> I'm against this. We will have multiple netconfig objects in play and each one
> would be utilizing an fd. We should be keeping our fd use to a minimum,
> particularly since we're limited to ~128 right now. Passing in the rtnl object
> from outside is preferred.
Makes sense. How about using a global rtnl object for all of the
l_netconfig objects? Do you still prefer that it be passed from
outside?
I did this later in patch 11 and maybe should have merged that change
directly here. We could also create it only after
l_netconfig_start().
Best regards
next reply other threads:[~2022-05-19 11:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 11:52 Andrew Zaborowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-05-19 21:38 [PATCH 07/17] netconfig: Use an internal rtnl socket for l_netconfig_apply_rtnl Andrew Zaborowski
2022-05-19 21:28 Denis Kenzior
2022-05-19 20:53 Andrew Zaborowski
2022-05-19 20:28 Denis Kenzior
2022-05-18 18:58 Denis Kenzior
2022-05-13 22:47 Andrew Zaborowski
2022-05-13 14:55 Andrew Zaborowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOq732JFUWwpJpg7BNAWH4JT5CnN-EHNLD_7eDERYEqaRwEqmQ@mail.gmail.com \
--to=ell@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).