From: Jens Axboe <axboe@kernel.dk>
To: fio@vger.kernel.org, Vincent Fu <vincentfu@gmail.com>,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: Damien Le Moal <dlemoal@kernel.org>,
Dmitry Fomichev <Dmitry.Fomichev@wdc.com>,
Niklas Cassel <niklas.cassel@wdc.com>
Subject: Re: [PATCH] zbd: avoid Coverity defect report
Date: Fri, 09 Jun 2023 18:05:05 -0600 [thread overview]
Message-ID: <168635550571.775565.15821160196830289017.b4-ty@kernel.dk> (raw)
In-Reply-To: <20230609235914.1376567-1-shinichiro.kawasaki@wdc.com>
On Sat, 10 Jun 2023 08:59:14 +0900, Shin'ichiro Kawasaki wrote:
> Coverity reported a defect related to the local variable "in_flight":
>
> Using an unreliable value of "in_flight" inside the second locked
> section. If the data that "in_flight" depends on was changed by
> another thread, this use might be incorrect.
>
> The variable "in_flight" is thread local and other threads can not
> change its value. Then the report should be false-positive. Just to
> suppress the report, change reference timing of the valuable.
>
> [...]
Applied, thanks!
[1/1] zbd: avoid Coverity defect report
commit: 62ac66490f5077e5fca1bd5b49165147cafc5a0d
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2023-06-10 0:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 23:59 [PATCH] zbd: avoid Coverity defect report Shin'ichiro Kawasaki
2023-06-10 0:05 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168635550571.775565.15821160196830289017.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=Dmitry.Fomichev@wdc.com \
--cc=dlemoal@kernel.org \
--cc=fio@vger.kernel.org \
--cc=niklas.cassel@wdc.com \
--cc=shinichiro.kawasaki@wdc.com \
--cc=vincentfu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).