From: Niklas Cassel <nks@flawful.org>
To: axboe@kernel.dk
Cc: fio@vger.kernel.org, dlemoal@kernel.org,
"Shin'ichiro Kawasaki" <shinichiro.kawasaki@wdc.com>,
Niklas Cassel <niklas.cassel@wdc.com>
Subject: [PATCH] Revert "zbd: Report the zone capacity"
Date: Thu, 27 Apr 2023 11:24:23 +0200 [thread overview]
Message-ID: <20230427092423.605250-1-nks@flawful.org> (raw)
From: Niklas Cassel <niklas.cassel@wdc.com>
This reverts commit 067c18eb3700373d029a9f2795d662453fc09cf4.
In the Linux zoned block devices API (blkzoned.h) (and in the NVMe Zoned
Namespace Command Set Specification), the zone capacity can be different
for each zone (unlike zone size, which has to be the same for all zones).
In order to not mislead the user to think that the zone capacity has to
be the same for all zones, remove the zone capacity for zone0 from the
per device print.
The zone capacity can be printed in prints that are related to a specific
zone, e.g. when encountering an error when performing I/O to a zone.
Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
---
zbd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/zbd.c b/zbd.c
index f5fb923a..351b3971 100644
--- a/zbd.c
+++ b/zbd.c
@@ -804,8 +804,8 @@ static int parse_zone_info(struct thread_data *td, struct fio_file *f)
goto out;
}
- dprint(FD_ZBD, "Device %s has %d zones of size %"PRIu64" KB and capacity %"PRIu64" KB\n",
- f->file_name, nr_zones, zone_size / 1024, zones[0].capacity / 1024);
+ dprint(FD_ZBD, "Device %s has %d zones of size %"PRIu64" KB\n",
+ f->file_name, nr_zones, zone_size / 1024);
zbd_info = scalloc(1, sizeof(*zbd_info) +
(nr_zones + 1) * sizeof(zbd_info->zone_info[0]));
--
2.40.0
next reply other threads:[~2023-04-27 9:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 9:24 Niklas Cassel [this message]
2023-04-27 18:39 ` [PATCH] Revert "zbd: Report the zone capacity" Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230427092423.605250-1-nks@flawful.org \
--to=nks@flawful.org \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=fio@vger.kernel.org \
--cc=niklas.cassel@wdc.com \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).