fio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ankit Kumar <ankit.kumar@samsung.com>
To: axboe@kernel.dk
Cc: fio@vger.kernel.org, vincentfu@gmail.com, joshi.k@samsung.com,
	Ankit Kumar <ankit.kumar@samsung.com>
Subject: [PATCH 0/1] io_uring_cmd engine extende LBA fixes and cleanup
Date: Mon,  8 May 2023 21:31:17 +0530	[thread overview]
Message-ID: <20230508160118.25334-1-ankit.kumar@samsung.com> (raw)
In-Reply-To: CGME20230508104106epcas5p30f01a4afec7405be8f46f99b73fa9207@epcas5p3.samsung.com

The io_uring_cmd ioengine assumes that logical block size is power of 2.
In case of extended LBA where metadata is transferred as part of LBA
this is not correct. Use division operation for that. The existing
calculation for power of 2 LBA remains the same.

The current implementation doesn't support protection info and
metadata transferred as separate buffer, return error for these
scenarios.

Add checks to verify that block sizes are multiple of LBA size.
Add support for 64 LBA formats as per the latest NVM command set
specification.

Ankit Kumar (1):
  engines/io_uring: io_uring_cmd engine cleanup and fixes

 engines/io_uring.c | 31 +++++++++++++++++++++----
 engines/nvme.c     | 57 +++++++++++++++++++++++++++++++++++++---------
 engines/nvme.h     |  3 ++-
 3 files changed, 75 insertions(+), 16 deletions(-)

-- 
2.25.1


       reply	other threads:[~2023-05-12  9:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230508104106epcas5p30f01a4afec7405be8f46f99b73fa9207@epcas5p3.samsung.com>
2023-05-08 16:01 ` Ankit Kumar [this message]
     [not found]   ` <CGME20230508104107epcas5p1f66b2d5c59293d9d902502e23add5c73@epcas5p1.samsung.com>
2023-05-08 16:01     ` [PATCH 1/1] engines/io_uring: io_uring_cmd engine cleanup and fixes Ankit Kumar
2023-05-12 16:47       ` Vincent Fu
2023-05-12 18:32         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230508160118.25334-1-ankit.kumar@samsung.com \
    --to=ankit.kumar@samsung.com \
    --cc=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    --cc=joshi.k@samsung.com \
    --cc=vincentfu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).