From: Vincent Fu <vincentfu@gmail.com>
To: Ankit Kumar <ankit.kumar@samsung.com>, axboe@kernel.dk
Cc: fio@vger.kernel.org
Subject: Re: [PATCH v2 2/2] docs: update fio man page for log_window_value
Date: Wed, 24 Jan 2024 07:02:11 -0500 [thread overview]
Message-ID: <629184d7-7dba-436f-8f09-ad4b917e04ce@gmail.com> (raw)
In-Reply-To: <20240124113413.52550-3-ankit.kumar@samsung.com>
On 1/24/24 06:34, Ankit Kumar wrote:
> Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
> ---
> HOWTO.rst | 45 +++++++++++++++++++++++++++++++++++----------
> fio.1 | 52 ++++++++++++++++++++++++++++++++++++++++------------
> 2 files changed, 75 insertions(+), 22 deletions(-)
>
> diff --git a/HOWTO.rst b/HOWTO.rst
> index d0ba8021..f83a8b53 100644
> --- a/HOWTO.rst
> +++ b/HOWTO.rst
> @@ -4067,7 +4067,7 @@ Measurements and reporting
> I/O that completes. When writing to the disk log, that can quickly grow to a
> very large size. Setting this option makes fio average the each log entry
> over the specified period of time, reducing the resolution of the log. See
> - :option:`log_max_value` as well. Defaults to 0, logging all entries.
> + :option:`log_window_value` as well. Defaults to 0, logging all entries.
> Also see `Log File Formats`_.
>
> .. option:: log_hist_msec=int
> @@ -4088,11 +4088,28 @@ Measurements and reporting
> histogram logs contain 1216 latency bins. See :option:`write_hist_log`
> and `Log File Formats`_.
>
> -.. option:: log_max_value=bool
> +.. option:: log_window_value=int, log_max_value=int
>
> - If :option:`log_avg_msec` is set, fio logs the average over that window. If
> - you instead want to log the maximum value, set this option to 1. Defaults to
> - 0, meaning that averaged values are logged.
> + If :option:`log_avg_msec` is set, fio by default logs the average over that
> + window. This option determines whether fio logs the average, maximum or
> + both the values over the window. This only affects the latency logging,
> + as both average and maximum values for iops or bw log will be same.
> + Accepted values are:
> +
> + **avg**
> + Log average value over the window. The default.
> +
> + **max**
> + Log maximum value in the window.
> +
> + **both**
> + Log both average and maximum value over the window.
> +
> + **0**
> + Backward-compatible alias for **avg**.
> +
> + **1**
> + Backward-compatible alias for **max**.
>
> .. option:: log_offset=bool
>
> @@ -5061,11 +5078,19 @@ toggled with :option:`log_offset`.
> by the ioengine specific :option:`cmdprio_percentage`.
>
> Fio defaults to logging every individual I/O but when windowed logging is set
> -through :option:`log_avg_msec`, either the average (by default) or the maximum
> -(:option:`log_max_value` is set) *value* seen over the specified period of time
> -is recorded. Each *data direction* seen within the window period will aggregate
> -its values in a separate row. Further, when using windowed logging the *block
> -size* and *offset* entries will always contain 0.
> +through :option:`log_lat_msec`, either the average (by default), the maximum
`log_lat_msec` should be `log_avg_msec`
prev parent reply other threads:[~2024-01-24 12:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240124061714epcas5p36e87ac4a06e9187bf8d818b04bd1c4cf@epcas5p3.samsung.com>
2024-01-24 11:34 ` [PATCH v2 0/2] log both average and max values over the window Ankit Kumar
[not found] ` <CGME20240124061715epcas5p108a25af87c320ac6875e6353f245b58f@epcas5p1.samsung.com>
2024-01-24 11:34 ` [PATCH v2 1/2] stat: log out both average and max " Ankit Kumar
[not found] ` <CGME20240124061716epcas5p3c60fd0138f74a40bd020f1f31a298a07@epcas5p3.samsung.com>
2024-01-24 11:34 ` [PATCH v2 2/2] docs: update fio man page for log_window_value Ankit Kumar
2024-01-24 12:02 ` Vincent Fu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=629184d7-7dba-436f-8f09-ad4b917e04ce@gmail.com \
--to=vincentfu@gmail.com \
--cc=ankit.kumar@samsung.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).