From: Jens Axboe <axboe@kernel.dk>
To: Ankit Kumar <ankit.kumar@samsung.com>, vincentfu@gmail.com
Cc: fio@vger.kernel.org, joshi.k@samsung.com
Subject: Re: [PATCH 0/2] E2E PI two small fixes for io_uring passthru engine.
Date: Mon, 11 Sep 2023 10:56:24 -0600 [thread overview]
Message-ID: <be158fdb-c368-41e4-bbf0-bd1ff4a073e9@kernel.dk> (raw)
In-Reply-To: <20230911162500.271118-1-ankit.kumar@samsung.com>
On 9/11/23 10:24 AM, Ankit Kumar wrote:
> 1. The fio verify cannot work when end to end data protection is enabled
> This issue is only when nvme namespace has extended logical blocks, as
> the PI portion of data buffer conflicts with any specified verify
> option. Disallow verify for this case.
> 2. There is no need to fill LBA reference and application tag in the
> command if the relevant bits for PI check is not set.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2023-09-11 22:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230911110620epcas5p20ba906dcc78e21b1936dd37e5b5a1090@epcas5p2.samsung.com>
2023-09-11 16:24 ` [PATCH 0/2] E2E PI two small fixes for io_uring passthru engine Ankit Kumar
[not found] ` <CGME20230911110621epcas5p42694479993ca275323ce86d39b29b5f7@epcas5p4.samsung.com>
2023-09-11 16:24 ` [PATCH 1/2] engines:io_uring_cmd: disallow verify for e2e pi with extended blocks Ankit Kumar
[not found] ` <CGME20230911110622epcas5p1603928810e5dff20d2cdb2f612b28120@epcas5p1.samsung.com>
2023-09-11 16:25 ` [PATCH 2/2] engines:nvme: fill command fields as per pi check bits Ankit Kumar
2023-09-11 16:56 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be158fdb-c368-41e4-bbf0-bd1ff4a073e9@kernel.dk \
--to=axboe@kernel.dk \
--cc=ankit.kumar@samsung.com \
--cc=fio@vger.kernel.org \
--cc=joshi.k@samsung.com \
--cc=vincentfu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).