From: Andrey Albershteyn <aalbersh@redhat.com>
To: djwong@kernel.org, dchinner@redhat.com, ebiggers@kernel.org,
hch@infradead.org, linux-xfs@vger.kernel.org,
fsverity@lists.linux.dev
Cc: rpeterso@redhat.com, agruenba@redhat.com, xiang@kernel.org,
chao@kernel.org, damien.lemoal@opensource.wdc.com,
jth@kernel.org, linux-erofs@lists.ozlabs.org,
linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
Andrey Albershteyn <aalbersh@redhat.com>
Subject: [PATCH v2 00/23] fs-verity support for XFS
Date: Tue, 4 Apr 2023 16:52:56 +0200 [thread overview]
Message-ID: <20230404145319.2057051-1-aalbersh@redhat.com> (raw)
Hi all,
This is V2 of fs-verity support in XFS. In this series I did
numerous changes from V1 which are described below.
This patchset introduces fs-verity [5] support for XFS. This
implementation utilizes extended attributes to store fs-verity
metadata. The Merkle tree blocks are stored in the remote extended
attributes.
A few key points:
- fs-verity metadata is stored in extended attributes
- Direct path and DAX are disabled for inodes with fs-verity
- Pages are verified in iomap's read IO path (offloaded to
workqueue)
- New workqueue for verification processing
- New ro-compat flag
- Inodes with fs-verity have new on-disk diflag
- xfs_attr_get() can return buffer with the attribute
The patchset is tested with xfstests -g auto on xfs_1k, xfs_4k,
xfs_1k_quota, and xfs_4k_quota. Haven't found any major failures.
Patches [6/23] and [7/23] touch ext4, f2fs, btrfs, and patch [8/23]
touches erofs, gfs2, and zonefs.
The patchset consist of four parts:
- [1..4]: Patches from Parent Pointer patchset which add binary
xattr names with a few deps
- [5..7]: Improvements to core fs-verity
- [8..9]: Add read path verification to iomap
- [10..23]: Integration of fs-verity to xfs
Changes from V1:
- Added parent pointer patches for easier testing
- Many issues and refactoring points fixed from the V1 review
- Adjusted for recent changes in fs-verity core (folios, non-4k)
- Dropped disabling of large folios
- Completely new fsverity patches (fix, callout, log_blocksize)
- Change approach to verification in iomap to the same one as in
write path. Callouts to fs instead of direct fs-verity use.
- New XFS workqueue for post read folio verification
- xfs_attr_get() can return underlying xfs_buf
- xfs_bufs are marked with XBF_VERITY_CHECKED to track verified
blocks
kernel:
[1]: https://github.com/alberand/linux/tree/xfs-verity-v2
xfsprogs:
[2]: https://github.com/alberand/xfsprogs/tree/fsverity-v2
xfstests:
[3]: https://github.com/alberand/xfstests/tree/fsverity-v2
v1:
[4]: https://lore.kernel.org/linux-xfs/20221213172935.680971-1-aalbersh@redhat.com/
fs-verity:
[5]: https://www.kernel.org/doc/html/latest/filesystems/fsverity.html
Thanks,
Andrey
Allison Henderson (4):
xfs: Add new name to attri/d
xfs: add parent pointer support to attribute code
xfs: define parent pointer xattr format
xfs: Add xfs_verify_pptr
Andrey Albershteyn (19):
fsverity: make fsverity_verify_folio() accept folio's offset and size
fsverity: add drop_page() callout
fsverity: pass Merkle tree block size to ->read_merkle_tree_page()
iomap: hoist iomap_readpage_ctx from the iomap_readahead/_folio
iomap: allow filesystem to implement read path verification
xfs: add XBF_VERITY_CHECKED xfs_buf flag
xfs: add XFS_DA_OP_BUFFER to make xfs_attr_get() return buffer
xfs: introduce workqueue for post read IO work
xfs: add iomap's readpage operations
xfs: add attribute type for fs-verity
xfs: add fs-verity ro-compat flag
xfs: add inode on-disk VERITY flag
xfs: initialize fs-verity on file open and cleanup on inode
destruction
xfs: don't allow to enable DAX on fs-verity sealsed inode
xfs: disable direct read path for fs-verity sealed files
xfs: add fs-verity support
xfs: handle merkle tree block size != fs blocksize != PAGE_SIZE
xfs: add fs-verity ioctls
xfs: enable ro-compat fs-verity flag
fs/btrfs/verity.c | 15 +-
fs/erofs/data.c | 12 +-
fs/ext4/verity.c | 9 +-
fs/f2fs/verity.c | 9 +-
fs/gfs2/aops.c | 10 +-
fs/ioctl.c | 4 +
fs/iomap/buffered-io.c | 89 ++++++-----
fs/verity/read_metadata.c | 7 +-
fs/verity/verify.c | 9 +-
fs/xfs/Makefile | 1 +
fs/xfs/libxfs/xfs_attr.c | 81 +++++++++-
fs/xfs/libxfs/xfs_attr.h | 7 +-
fs/xfs/libxfs/xfs_attr_leaf.c | 7 +
fs/xfs/libxfs/xfs_attr_remote.c | 13 +-
fs/xfs/libxfs/xfs_da_btree.h | 7 +-
fs/xfs/libxfs/xfs_da_format.h | 46 +++++-
fs/xfs/libxfs/xfs_format.h | 14 +-
fs/xfs/libxfs/xfs_log_format.h | 8 +-
fs/xfs/libxfs/xfs_sb.c | 2 +
fs/xfs/scrub/attr.c | 4 +-
fs/xfs/xfs_aops.c | 61 +++++++-
fs/xfs/xfs_attr_item.c | 142 +++++++++++++++---
fs/xfs/xfs_attr_item.h | 1 +
fs/xfs/xfs_attr_list.c | 17 ++-
fs/xfs/xfs_buf.h | 17 ++-
fs/xfs/xfs_file.c | 22 ++-
fs/xfs/xfs_inode.c | 2 +
fs/xfs/xfs_inode.h | 3 +-
fs/xfs/xfs_ioctl.c | 22 +++
fs/xfs/xfs_iomap.c | 14 ++
fs/xfs/xfs_iops.c | 4 +
fs/xfs/xfs_linux.h | 1 +
fs/xfs/xfs_mount.h | 3 +
fs/xfs/xfs_ondisk.h | 4 +
fs/xfs/xfs_super.c | 19 +++
fs/xfs/xfs_trace.h | 1 +
fs/xfs/xfs_verity.c | 256 ++++++++++++++++++++++++++++++++
fs/xfs/xfs_verity.h | 27 ++++
fs/xfs/xfs_xattr.c | 9 ++
fs/zonefs/file.c | 12 +-
include/linux/fsverity.h | 18 ++-
include/linux/iomap.h | 39 ++++-
include/uapi/linux/fs.h | 1 +
43 files changed, 923 insertions(+), 126 deletions(-)
create mode 100644 fs/xfs/xfs_verity.c
create mode 100644 fs/xfs/xfs_verity.h
--
2.38.4
next reply other threads:[~2023-04-04 14:54 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 14:52 Andrey Albershteyn [this message]
2023-04-04 14:52 ` [PATCH v2 01/23] xfs: Add new name to attri/d Andrey Albershteyn
2023-04-04 14:52 ` [PATCH v2 02/23] xfs: add parent pointer support to attribute code Andrey Albershteyn
2023-04-04 14:52 ` [PATCH v2 03/23] xfs: define parent pointer xattr format Andrey Albershteyn
2023-04-04 14:53 ` [PATCH v2 04/23] xfs: Add xfs_verify_pptr Andrey Albershteyn
2023-04-04 14:53 ` [PATCH v2 05/23] fsverity: make fsverity_verify_folio() accept folio's offset and size Andrey Albershteyn
2023-04-04 15:30 ` Christoph Hellwig
2023-04-05 10:36 ` Andrey Albershteyn
2023-04-05 15:46 ` Christoph Hellwig
2023-04-05 17:50 ` Eric Biggers
2023-04-04 14:53 ` [PATCH v2 06/23] fsverity: add drop_page() callout Andrey Albershteyn
2023-04-04 23:40 ` Dave Chinner
2023-04-05 10:39 ` Andrey Albershteyn
2023-04-04 14:53 ` [PATCH v2 07/23] fsverity: pass Merkle tree block size to ->read_merkle_tree_page() Andrey Albershteyn
2023-04-04 14:53 ` [PATCH v2 08/23] iomap: hoist iomap_readpage_ctx from the iomap_readahead/_folio Andrey Albershteyn
2023-04-04 15:32 ` Christoph Hellwig
2023-04-04 14:53 ` [PATCH v2 09/23] iomap: allow filesystem to implement read path verification Andrey Albershteyn
2023-04-04 15:37 ` Christoph Hellwig
2023-04-05 11:01 ` Andrey Albershteyn
2023-04-05 15:06 ` Darrick J. Wong
2023-04-05 15:48 ` Christoph Hellwig
2023-04-04 14:53 ` [PATCH v2 10/23] xfs: add XBF_VERITY_CHECKED xfs_buf flag Andrey Albershteyn
2023-04-04 14:53 ` [PATCH v2 11/23] xfs: add XFS_DA_OP_BUFFER to make xfs_attr_get() return buffer Andrey Albershteyn
2023-04-04 14:53 ` [PATCH v2 12/23] xfs: introduce workqueue for post read IO work Andrey Albershteyn
2023-04-04 14:53 ` [PATCH v2 13/23] xfs: add iomap's readpage operations Andrey Albershteyn
2023-04-04 14:53 ` [PATCH v2 14/23] xfs: add attribute type for fs-verity Andrey Albershteyn
2023-04-04 14:53 ` [PATCH v2 15/23] xfs: add fs-verity ro-compat flag Andrey Albershteyn
2023-04-04 14:53 ` [PATCH v2 16/23] xfs: add inode on-disk VERITY flag Andrey Albershteyn
2023-04-04 22:41 ` Eric Biggers
2023-04-04 23:56 ` Dave Chinner
2023-04-05 11:07 ` Andrey Albershteyn
2023-04-04 14:53 ` [PATCH v2 17/23] xfs: initialize fs-verity on file open and cleanup on inode destruction Andrey Albershteyn
2023-04-04 14:53 ` [PATCH v2 18/23] xfs: don't allow to enable DAX on fs-verity sealsed inode Andrey Albershteyn
2023-04-04 14:53 ` [PATCH v2 19/23] xfs: disable direct read path for fs-verity sealed files Andrey Albershteyn
2023-04-04 16:10 ` Darrick J. Wong
2023-04-05 15:01 ` Andrey Albershteyn
2023-04-05 15:09 ` Darrick J. Wong
2023-04-05 15:50 ` Christoph Hellwig
2023-04-05 18:02 ` Eric Biggers
2023-04-05 22:14 ` Dave Chinner
2023-04-05 22:10 ` Dave Chinner
2023-04-04 14:53 ` [PATCH v2 20/23] xfs: add fs-verity support Andrey Albershteyn
2023-04-04 16:27 ` Darrick J. Wong
2023-04-05 15:18 ` Eric Sandeen
2023-04-04 18:01 ` kernel test robot
2023-04-04 20:03 ` kernel test robot
2023-04-04 14:53 ` [PATCH v2 21/23] xfs: handle merkle tree block size != fs blocksize != PAGE_SIZE Andrey Albershteyn
2023-04-04 16:36 ` Darrick J. Wong
2023-04-05 16:02 ` Andrey Albershteyn
2023-04-05 16:38 ` Darrick J. Wong
2023-04-05 18:16 ` Eric Biggers
2023-04-05 22:26 ` Dave Chinner
2023-04-05 22:54 ` Eric Biggers
2023-04-05 23:37 ` Dave Chinner
2023-04-06 0:44 ` Eric Biggers
2023-04-07 19:56 ` Eric Biggers
2023-04-04 23:32 ` Eric Biggers
2023-04-05 15:12 ` Andrey Albershteyn
2023-04-05 22:51 ` Dave Chinner
2023-04-04 14:53 ` [PATCH v2 22/23] xfs: add fs-verity ioctls Andrey Albershteyn
2023-04-04 14:53 ` [PATCH v2 23/23] xfs: enable ro-compat fs-verity flag Andrey Albershteyn
2023-04-04 16:39 ` [PATCH v2 00/23] fs-verity support for XFS Darrick J. Wong
2023-04-05 16:27 ` Andrey Albershteyn
2023-04-04 23:37 ` Eric Biggers
2023-04-05 16:04 ` Andrey Albershteyn
2023-04-11 5:19 ` Christoph Hellwig
2023-04-12 2:33 ` Eric Biggers
2023-04-12 3:18 ` Dave Chinner
2023-04-12 12:42 ` Christoph Hellwig
2023-04-12 12:40 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404145319.2057051-1-aalbersh@redhat.com \
--to=aalbersh@redhat.com \
--cc=agruenba@redhat.com \
--cc=chao@kernel.org \
--cc=cluster-devel@redhat.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=ebiggers@kernel.org \
--cc=fsverity@lists.linux.dev \
--cc=hch@infradead.org \
--cc=jth@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-xfs@vger.kernel.org \
--cc=rpeterso@redhat.com \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).