gfs2.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Andreas Gruenbacher <agruenba@redhat.com>
To: gfs2@lists.linux.dev
Cc: Andreas Gruenbacher <agruenba@redhat.com>
Subject: [PATCH 0/3] gfs2: do_xmote fixes
Date: Tue, 16 Apr 2024 12:10:47 +0200	[thread overview]
Message-ID: <20240416101050.636697-1-agruenba@redhat.com> (raw)
In-Reply-To: <20240411135243.260020-1-agruenba@redhat.com>

A closer review of commit 86934198eefa ("gfs2: Clear flags when withdraw
prevents xmote") has revealed that this commit got things very wrong and
that a more thorough cleanup of function do_xmote() is in order.  Here
is a set of three patches for doing that:

gfs2: finish_xmote cleanup

  Pushes more of the glock spin lock logic into do_xmote() which then
  allows to simplify things there.

gfs2: Fix do_xmote locking error

  The actual do_xmote() fixes and cleanup.

gfs2: Remove and replace gfs2_glock_queue_work

  A follow-up cleanup now that the previous patch has eliminated the last
  user of gfs2_glock_queue_work().

This obsoletes the previous patch "gfs2: Fix do_xmote locking error"
(https://lore.kernel.org/gfs2/20240411135243.260020-1-agruenba@redhat.com/).

Thanks,
Andreas

Andreas Gruenbacher (3):
  gfs2: finish_xmote cleanup
  gfs2: do_xmote fixes
  gfs2: Remove and replace gfs2_glock_queue_work

 fs/gfs2/glock.c | 78 ++++++++++++++++++++++++++-----------------------
 1 file changed, 42 insertions(+), 36 deletions(-)

-- 
2.44.0


  reply	other threads:[~2024-04-16 10:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-11 13:52 [PATCH] gfs2: Fix do_xmote locking error Andreas Gruenbacher
2024-04-16 10:10 ` Andreas Gruenbacher [this message]
2024-04-16 10:10   ` [PATCH 1/3] gfs2: finish_xmote cleanup Andreas Gruenbacher
2024-04-16 10:10   ` [PATCH 2/3] gfs2: do_xmote fixes Andreas Gruenbacher
2024-04-16 10:10   ` [PATCH 3/3] gfs2: Remove and replace gfs2_glock_queue_work Andreas Gruenbacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240416101050.636697-1-agruenba@redhat.com \
    --to=agruenba@redhat.com \
    --cc=gfs2@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).