From: Hongfu Li <lihongfu@kylinos.cn>
To: markus.elfring@web.de
Cc: aahringo@redhat.com, gfs2@lists.linux.dev, lihongfu@kylinos.cn,
linux-kernel@vger.kernel.org, teigland@redhat.com
Subject: Re: [PATCH] dlm: use KMEM_CACHE() in dlm_memory_init()
Date: Fri, 21 Jun 2024 15:55:33 +0800 [thread overview]
Message-ID: <20240621075533.86674-1-lihongfu@kylinos.cn> (raw)
In-Reply-To: <dec3e8d9-0a29-4e9b-afb5-888aaef4780d@web.de>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 752 bytes --]
>>> Can the three passed name strings matter still for the identification
>>> of the created caches from this function implementation?
>>> https://elixir.bootlin.com/linux/v6.10-rc4/source/fs/dlm/memory.c#L27
>>> https://elixir.bootlin.com/linux/v6.10-rc4/source/mm/slab_common.c#L362
>>
>> probably only for "dlm_cb" that turns into "dlm_callback".
>…
>
>Will the development attention grow for deviations of passed name strings
>from applied data structure identifiers?
My initial purpose is to replace kmem_cache_create() with KMEM_CACHE().
In my view，there is no problem in unifying passed name strings and
structure identifiers.
Maybe that's wrong，I will resubmit a patch that does not change
"dlm_cb" to "dlm_callback".
thanks,
Hongfu Li
next prev parent reply other threads:[~2024-06-21 7:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 5:03 [PATCH] dlm: use KMEM_CACHE in dlm_memory_init Hongfu Li
2024-06-19 20:48 ` [PATCH] dlm: use KMEM_CACHE() in dlm_memory_init() Markus Elfring
2024-06-19 21:33 ` Alexander Aring
2024-06-20 6:33 ` Markus Elfring
2024-06-21 7:55 ` Hongfu Li [this message]
2024-06-21 8:40 ` Markus Elfring
2024-06-21 10:39 ` Hongfu Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240621075533.86674-1-lihongfu@kylinos.cn \
--to=lihongfu@kylinos.cn \
--cc=aahringo@redhat.com \
--cc=gfs2@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.elfring@web.de \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).