From: Markus Elfring <Markus.Elfring@web.de>
To: Hongfu Li <lihongfu@kylinos.cn>, gfs2@lists.linux.dev
Cc: LKML <linux-kernel@vger.kernel.org>,
Alexander Aring <aahringo@redhat.com>,
David Teigland <teigland@redhat.com>,
Julia Lawall <julia.lawall@inria.fr>
Subject: Re: dlm: use KMEM_CACHE() in dlm_memory_init()
Date: Fri, 21 Jun 2024 10:40:32 +0200 [thread overview]
Message-ID: <5094e8bf-6eb6-43e4-80de-052e9c0c67c0@web.de> (raw)
In-Reply-To: <20240621075533.86674-1-lihongfu@kylinos.cn>
>>>> https://elixir.bootlin.com/linux/v6.10-rc4/source/fs/dlm/memory.c#L27
>>>> https://elixir.bootlin.com/linux/v6.10-rc4/source/mm/slab_common.c#L362
>>>
>>> probably only for "dlm_cb" that turns into "dlm_callback".
>> …
>>
>> Will the development attention grow for deviations of passed name strings
>> from applied data structure identifiers?
>
> My initial purpose is to replace kmem_cache_create() with KMEM_CACHE().
Do you take any help from advanced analysis tools into account
for such transformation attempts?
Example for the semantic patch language (Coccinelle software):
[PATCH v2] Coccinelle: api: Add SmPL script “use_KMEM_CACHE.cocci”
https://lore.kernel.org/cocci/b08603d6-cac1-4876-a56c-30c680d5dc52@web.de/
https://sympa.inria.fr/sympa/arc/cocci/2024-02/msg00000.html
> In my view，there is no problem in unifying passed name strings and
> structure identifiers.
> Maybe that's wrong，
I suggest to take another look also at feedback which other contributors
(from your Linux software distribution) got for similar change suggestions.
> I will resubmit a patch that does not change "dlm_cb" to "dlm_callback".
Do you see further opportunities to improve the change description accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc4#n94
Regards,
Markus
next prev parent reply other threads:[~2024-06-21 8:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 5:03 [PATCH] dlm: use KMEM_CACHE in dlm_memory_init Hongfu Li
2024-06-19 20:48 ` [PATCH] dlm: use KMEM_CACHE() in dlm_memory_init() Markus Elfring
2024-06-19 21:33 ` Alexander Aring
2024-06-20 6:33 ` Markus Elfring
2024-06-21 7:55 ` [PATCH] " Hongfu Li
2024-06-21 8:40 ` Markus Elfring [this message]
2024-06-21 10:39 ` Hongfu Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5094e8bf-6eb6-43e4-80de-052e9c0c67c0@web.de \
--to=markus.elfring@web.de \
--cc=aahringo@redhat.com \
--cc=gfs2@lists.linux.dev \
--cc=julia.lawall@inria.fr \
--cc=lihongfu@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).