From: Andreas Gruenbacher <agruenba@redhat.com>
To: gfs2@lists.linux.dev
Subject: Re: [PATCH 14/15] gfs2: Get rid of demote_ok checks
Date: Fri, 12 Apr 2024 08:00:00 +0200 [thread overview]
Message-ID: <CAHc6FU6H9CL0Z3GpMR6+DDTvtXjR8RszmQd=FaLTwae7xGY=Zg@mail.gmail.com> (raw)
In-Reply-To: <20240409164508.79570-15-agruenba@redhat.com>
On Tue, Apr 9, 2024 at 6:45 PM Andreas Gruenbacher <agruenba@redhat.com> wrote:
> The demote_ok glock operation is only still used to prevent the inode
> glocks of the "jindex" and "rindex" directories from getting recycled
> while they are still referenced by sdp->sd_jindex and sdp->sd_rindex.
> However, the LRU walking code will no longer recycle glocks which are
> referenced, so the demote_ok glock operation is obsolete and can be
> removed.
>
> Each of a glock's holders in the gl_holders list is holding a reference
> on the glock, so when the list of holders isn't empty in demote_ok(),
> the existing reference count check will already prevent the glock from
> getting released. This means that demote_ok() is obsolete as well.
This patch only works after a few additional patches I haven't posted
yet. I'm removing it from for-next for now and I'll repost later.
Thanks,
Andreas
next prev parent reply other threads:[~2024-04-12 6:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 16:44 [PATCH 00/15] gfs2 cleanups and fixes Andreas Gruenbacher
2024-04-09 16:44 ` [PATCH 01/15] gfs2: Get rid of newlines in log messages Andreas Gruenbacher
2024-04-09 16:44 ` [PATCH 02/15] gfs2: Remove unnecessary gfs2_meta_check_ii argument Andreas Gruenbacher
2024-04-09 16:44 ` [PATCH 03/15] gfs2: Follow-up to flag rename in sysfs status file Andreas Gruenbacher
2024-04-09 16:44 ` [PATCH 04/15] gfs2: Use [NO_]CREATE consistently for gfs2_glock_get Andreas Gruenbacher
2024-04-09 16:44 ` [PATCH 05/15] gfs2: Don't forget to complete delayed withdraw Andreas Gruenbacher
2024-04-09 16:44 ` [PATCH 06/15] gfs2: Fix NULL pointer dereference in gfs2_log_flush Andreas Gruenbacher
2024-04-09 16:44 ` [PATCH 07/15] gfs2: Get rid of gfs2_glock_queue_put in signal_our_withdraw Andreas Gruenbacher
2024-04-09 16:44 ` [PATCH 08/15] gfs2: Replace gfs2_glock_queue_put with gfs2_glock_put_async Andreas Gruenbacher
2024-04-09 16:44 ` [PATCH 09/15] gfs2: Don't set GLF_LOCK in gfs2_dispose_glock_lru Andreas Gruenbacher
2024-04-09 16:45 ` [PATCH 10/15] gfs2: Get rid of unnecessary test_and_set_bit Andreas Gruenbacher
2024-04-09 16:45 ` [PATCH 11/15] gfs2: Fix "ignore unlock failures after withdraw" Andreas Gruenbacher
2024-04-09 16:45 ` [PATCH 12/15] Revert "gfs2: fix glock shrinker ref issues" Andreas Gruenbacher
2024-04-09 16:45 ` [PATCH 13/15] gfs2: Fix "Make glock lru list scanning safer" Andreas Gruenbacher
2024-04-16 16:55 ` Andrew Price
2024-04-17 7:55 ` Andreas Gruenbacher
2024-04-09 16:45 ` [PATCH 14/15] gfs2: Get rid of demote_ok checks Andreas Gruenbacher
2024-04-12 6:00 ` Andreas Gruenbacher [this message]
2024-04-09 16:45 ` [PATCH 15/15] gfs2: Fix lru_count accounting Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHc6FU6H9CL0Z3GpMR6+DDTvtXjR8RszmQd=FaLTwae7xGY=Zg@mail.gmail.com' \
--to=agruenba@redhat.com \
--cc=gfs2@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).