From: Linus Torvalds <torvalds@linux-foundation.org>
To: David Teigland <teigland@redhat.com>
Cc: linux-kernel@vger.kernel.org, gfs2@lists.linux.dev
Subject: Re: [GIT PULL v2] dlm fixes for 6.9
Date: Mon, 18 Mar 2024 15:44:15 -0700 [thread overview]
Message-ID: <CAHk-=wjnxmpk1L9+ibbZmia0qNNwa8Qnk31_57O-DZqQfL08OQ@mail.gmail.com> (raw)
In-Reply-To: <ZfixMxRWFNmkf-Ta@redhat.com>
On Mon, 18 Mar 2024 at 14:25, David Teigland <teigland@redhat.com> wrote:
>
> I dropped the commit with the bad atomic usage, and replaced it with two
> other commits: the first reverts the unnecessary change that began using
> atomic_t for lkb_wait_count, and the second adds comments to the recovery
> code that forcibly resets the wait_count state.
Ok, the diff certainly looks saner. I didn't look at the code outside
the context of the diff, so that's literally just going by the patches
themselves, but I appreciate the comment ("The wait_count will almost
always be 1, but in case of an overlapping unlock/cancel it could be
2: see ..") and yes, it just makes the old atomic thing sound even
odder.
Thanks,
Linus
next prev parent reply other threads:[~2024-03-18 22:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 21:25 [GIT PULL v2] dlm fixes for 6.9 David Teigland
2024-03-18 22:44 ` Linus Torvalds [this message]
2024-03-18 22:47 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wjnxmpk1L9+ibbZmia0qNNwa8Qnk31_57O-DZqQfL08OQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=gfs2@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).