From: "Andreas Grünbacher" <andreas.gruenbacher@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andreas Gruenbacher <agruenba@redhat.com>,
gfs2@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] gfs2 fixes
Date: Tue, 7 Nov 2023 23:18:33 +0100 [thread overview]
Message-ID: <CAHpGcM+u=77p_k8dZ6gKu84wnkdvGYA4E6=MXqNw=ZY+ejjiaw@mail.gmail.com> (raw)
In-Reply-To: <CAHk-=wie7WsYHkEChV0hpcf7CRRJQw9-E8O8RxrFGKF6mEJ73g@mail.gmail.com>
Am Di., 7. Nov. 2023 um 21:31 Uhr schrieb Linus Torvalds
<torvalds@linux-foundation.org>:
> On Tue, 7 Nov 2023 at 06:22, Andreas Gruenbacher <agruenba@redhat.com> wrote:
> >
> > please consider pulling the following gfs2 fixes.
>
> You are officially on my shit-list for
>
> (a) claiming it's fixes
>
> (b) apparently lying about that fact to make it appear that it's ok
> that this wasn't in linux-next and was committed within the last few
> days
>
> about half of the commits in that pull request are very recent,
> weren't in linux-next when the merge window started, and while a
> couple of of them are fixes, most of them are just minor cleanups.
>
> DON'T LIE ABOUT THINGS. It only annoys the hell out of me when I
> notice that somebody was trying to pull wool over my eyes.
I apologize for referring to the entire set of commits as fixes when
it's really fixes and various other things. I've said so in the tag
description, but I realize now that that's not good enough. Lying
about what those commits are wasn't my intention though.
And I apologize for the last -minute changes. There is one commit that
removes a single line of dead code which could easily have waited. The
rest are fixes, but they should have been completed much sooner.
That's entirely my fault.
> I've pulled this and I'll let it be (because I already merged other
> stuff on top), but dammit, just be honest about what happened, don't
> try to claim this is somehow "fixes" and thus ok to not have gone
> through linux-next.
>
> Or, better yet, get your ducks actually lined up before the merge window.
>
> Linus
Thanks,
Andreas
next prev parent reply other threads:[~2023-11-07 22:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 14:21 [GIT PULL] gfs2 fixes Andreas Gruenbacher
2023-11-07 20:30 ` Linus Torvalds
2023-11-07 22:18 ` Andreas Grünbacher [this message]
2023-11-08 0:04 ` Linus Torvalds
2023-11-07 20:34 ` pr-tracker-bot
-- strict thread matches above, loose matches on Subject: below --
2023-09-18 14:34 Andreas Gruenbacher
2023-09-18 20:20 ` pr-tracker-bot
2023-09-05 16:12 Andreas Gruenbacher
2023-09-05 20:14 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHpGcM+u=77p_k8dZ6gKu84wnkdvGYA4E6=MXqNw=ZY+ejjiaw@mail.gmail.com' \
--to=andreas.gruenbacher@gmail.com \
--cc=agruenba@redhat.com \
--cc=gfs2@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).