From: Alexander Aring <aahringo@redhat.com>
To: teigland@redhat.com
Cc: gfs2@lists.linux.dev
Subject: Re: [RFC v6.8-rc6 6/7] dlm: fix race between final callback and remove
Date: Wed, 13 Mar 2024 09:46:48 -0400 [thread overview]
Message-ID: <CAK-6q+gUrY7EaNSiOJfgtf-SgHsC8N+dQOCL8X+3_bMFuuSu9g@mail.gmail.com> (raw)
In-Reply-To: <20240308161818.2388451-7-aahringo@redhat.com>
Hi,
On Fri, Mar 8, 2024 at 11:18 AM Alexander Aring <aahringo@redhat.com> wrote:
...
>
> - spin_lock(&lkb->lkb_cb_lock);
> - rv = dlm_enqueue_lkb_callback(lkb, flags, mode, status, sbflags);
> + rv = dlm_queue_lkb_callback(lkb, flags, mode, status, sbflags,
> + &cb);
> switch (rv) {
> case DLM_ENQUEUE_CALLBACK_NEED_SCHED:
> - kref_get(&lkb->lkb_ref);
> + cb->astfn = lkb->lkb_astfn;
> + cb->bastfn = lkb->lkb_bastfn;
> + cb->astparam = lkb->lkb_astparam;
> + INIT_WORK(&cb->work, dlm_callback_work);
>
> spin_lock(&ls->ls_cb_lock);
> if (test_bit(LSFL_CB_DELAY, &ls->ls_flags)) {
> - list_add(&lkb->lkb_cb_list, &ls->ls_cb_delay);
> + list_add(&cb->list, &ls->ls_cb_delay);
> + spin_unlock(&ls->ls_cb_lock);
> } else {
> - queue_work(ls->ls_callback_wq, &lkb->lkb_cb_work);
> + spin_unlock(&ls->ls_cb_lock);
> + queue_work(ls->ls_callback_wq, &cb->work);
The queue_work() needs to be protected by ls_cb_lock because it races
with flush_workqueue() and LSFL_CB_DELAY setting.
- Alex
next prev parent reply other threads:[~2024-03-13 13:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 16:18 [RFC v6.8-rc6 0/7] dlm: fix race between callback and remove message Alexander Aring
2024-03-08 16:18 ` [RFC v6.8-rc6 1/7] dlm: fix user space lock decision to copy lvb Alexander Aring
2024-03-10 14:27 ` Alexander Aring
2024-03-08 16:18 ` [RFC v6.8-rc6 2/7] dlm: remove lkb from ast bast tracepoints Alexander Aring
2024-03-08 16:18 ` [RFC v6.8-rc6 3/7] dlm: remove callback queue debugfs functionality Alexander Aring
2024-03-08 16:18 ` [RFC v6.8-rc6 4/7] dlm: move lkb debug information out of callback Alexander Aring
2024-03-08 16:18 ` [RFC v6.8-rc6 5/7] dlm: combine switch case fail and default statements Alexander Aring
2024-03-08 16:18 ` [RFC v6.8-rc6 6/7] dlm: fix race between final callback and remove Alexander Aring
2024-03-08 16:30 ` Alexander Aring
2024-03-13 13:46 ` Alexander Aring [this message]
2024-03-08 16:18 ` [RFC v6.8-rc6 7/7] dlm: remove callback reference counting Alexander Aring
2024-03-10 14:25 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK-6q+gUrY7EaNSiOJfgtf-SgHsC8N+dQOCL8X+3_bMFuuSu9g@mail.gmail.com \
--to=aahringo@redhat.com \
--cc=gfs2@lists.linux.dev \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).