From: Alexander Aring <aahringo@redhat.com>
To: Zorro Lang <zlang@redhat.com>
Cc: fstests@vger.kernel.org, gfs2@lists.linux.dev, jlayton@kernel.org
Subject: Re: [PATCHv2] generic: add fcntl corner cases tests
Date: Tue, 2 Apr 2024 10:56:32 -0400 [thread overview]
Message-ID: <CAK-6q+h9Oy1A3ZSR=d52ckijVZbAi4zufnE0KkLhMfMi+kY-Dg@mail.gmail.com> (raw)
In-Reply-To: <20240330072500.qs73uzweykk3npsq@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>
Hi,
On Sat, Mar 30, 2024 at 3:25 AM Zorro Lang <zlang@redhat.com> wrote:
>
> On Mon, Sep 25, 2023 at 04:18:27PM -0400, Alexander Aring wrote:
> > This patch adds fcntl corner cases that was being used to confirm issues
> > on a GFS2 filesystem. The GFS2 filesystem has it's own ->lock()
> > implementation and in those corner cases issues was being found and
> > fixed.
> >
> > Signed-off-by: Alexander Aring <aahringo@redhat.com>
> > ---
> > changes since v2:
> > - move fcntl tests into one fcntl c file
> > - remove ofd and same owner tests, should be reflected by only one test
> > - simplify commit message (remove testname out of it)
> > - add error messages in fcntl.c to give more information if an error
> > occur
>
> Any update? :) It's still in "patches-in-queue" branch.
I still have it on my list to work on this.
Thanks for all the recommendations for another version. I hope I can
provide an update soon. What is about the CIFS issue, we will ignore
it for now? From my understanding it is an issue in CIFS but probably
rare to hit and not easy to fix for now.
(report after hang) I can look if we can add an alarm() type
interruption, but this only work if the filesystem really implements
that fcntl(..., F_SETLKW, ...) is interruptible which should be the
case, otherwise it would be another exception why the test is know to
be failing.
Thanks.
- Alex
prev parent reply other threads:[~2024-04-02 14:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 20:18 [PATCHv2] generic: add fcntl corner cases tests Alexander Aring
2023-11-02 14:37 ` Alexander Aring
2024-02-01 15:03 ` Alexander Aring
2024-02-01 17:10 ` Jeff Layton
2024-02-02 12:04 ` Zorro Lang
2024-02-02 12:19 ` Alexander Aring
2024-02-02 12:27 ` Zorro Lang
2024-02-02 12:36 ` Jeff Layton
2024-02-02 12:46 ` Zorro Lang
2024-02-09 5:26 ` Zorro Lang
2024-02-09 5:35 ` Steve French
2024-02-09 11:43 ` Zorro Lang
2024-03-01 10:38 ` Zorro Lang
2024-03-01 14:08 ` Alexander Aring
2024-03-01 16:25 ` Paulo Alcantara
2024-03-01 17:23 ` Alexander Aring
2024-03-01 23:59 ` Paulo Alcantara
2024-03-03 5:08 ` Zorro Lang
2024-03-07 15:58 ` Anand Jain
2024-03-30 7:25 ` Zorro Lang
2024-04-02 14:56 ` Alexander Aring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK-6q+h9Oy1A3ZSR=d52ckijVZbAi4zufnE0KkLhMfMi+kY-Dg@mail.gmail.com' \
--to=aahringo@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=gfs2@lists.linux.dev \
--cc=jlayton@kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).