From: Alexander Aring <aahringo@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: peterz@infradead.org, will@kernel.org, gfs2@lists.linux.dev,
boqun.feng@gmail.com, mark.rutland@arm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] refcount: move kdoc to header definition
Date: Thu, 9 Nov 2023 09:15:13 -0500 [thread overview]
Message-ID: <CAK-6q+jK7L=Vg6UAr=_vKbywBpQTMcor_1cU75tjx0tT2qNndQ@mail.gmail.com> (raw)
In-Reply-To: <ZUyDvv0na03qnSH+@infradead.org>
Hi,
On Thu, Nov 9, 2023 at 2:10 AM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Mon, Nov 06, 2023 at 02:11:36PM -0500, Alexander Aring wrote:
> > This patch moves the kdoc for refcount_dec_and_lock functionality to
> > it's header prototype declarations.
>
> That's not how kerneldoc works. The comments should be next to the
> implementation.
>
ok, saved for next time. Thanks.
I will drop this patch.
- Alex
prev parent reply other threads:[~2023-11-09 14:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 19:11 [PATCH 1/3] refcount: move kdoc to header definition Alexander Aring
2023-11-06 19:11 ` [PATCH 2/3] refcount: introduce __refcount_dec_and_lock macro Alexander Aring
2023-11-09 9:31 ` Peter Zijlstra
2023-11-06 19:11 ` [PATCH 3/3] kref: introduce __kref_put_lock macro Alexander Aring
2023-11-09 7:01 ` [PATCH 1/3] refcount: move kdoc to header definition Christoph Hellwig
2023-11-09 14:15 ` Alexander Aring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK-6q+jK7L=Vg6UAr=_vKbywBpQTMcor_1cU75tjx0tT2qNndQ@mail.gmail.com' \
--to=aahringo@redhat.com \
--cc=boqun.feng@gmail.com \
--cc=gfs2@lists.linux.dev \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).