From: Jeff King <peff@peff.net>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/8] tightening ref handling outside of refs/
Date: Tue, 30 Apr 2024 06:45:30 -0400 [thread overview]
Message-ID: <20240430104530.GG1279403@coredump.intra.peff.net> (raw)
In-Reply-To: <Zi9oRuknlhfG1-WX@tanuki>
On Mon, Apr 29, 2024 at 11:28:38AM +0200, Patrick Steinhardt wrote:
> On Mon, Apr 29, 2024 at 04:42:38AM -0400, Jeff King wrote:
> > On Mon, Apr 29, 2024 at 04:15:13AM -0400, Jeff King wrote:
> >
> > > [1/8]: t0600: don't create ref outside of refs/
> > > [2/8]: t5619: use fully qualified refname for branch
> >
> > You can probably guess that I found these test cleanups only after
> > writing the rest of the series and seeing them fail. :)
> >
> > It turns out there is one more spot that is run only with reftables (so
> > CI caught it, but my local testing did not):
>
> Yeah, that's an issue by itself in my opinion. It's ultimately the
> reason why I change this to always run the backend-specific tests in
> [1].
Ah, I hadn't seen that series. Yes, I'd be very much in favor of that
change.
-Peff
next prev parent reply other threads:[~2024-04-30 10:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 8:15 [PATCH 0/8] tightening ref handling outside of refs/ Jeff King
2024-04-29 8:16 ` [PATCH 1/8] t0600: don't create ref " Jeff King
2024-04-29 8:36 ` [PATCH 0/8] tightening ref handling " Jeff King
2024-04-29 8:42 ` Jeff King
2024-04-29 9:28 ` Patrick Steinhardt
2024-04-30 10:45 ` Jeff King [this message]
2024-04-29 15:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430104530.GG1279403@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).