From: Justin Tobler <jltobler@gmail.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (May 2024, #04; Thu, 9)
Date: Fri, 10 May 2024 13:39:17 -0500 [thread overview]
Message-ID: <262znkm7vg77nzp5fadhfuqkcs6wapsuzd5dtvffoopszzoyia@uohyfeerbncl> (raw)
In-Reply-To: <Zj5I9J-l24Pk-10q@framework>
On 24/05/10 06:19PM, Patrick Steinhardt wrote:
> On Fri, May 10, 2024 at 08:35:16AM -0700, Junio C Hamano wrote:
> > "I read it and have no comments" is somewhere between "an invitation
> > to miss" and "it does not highlight anything, either positive or
> > negative. Was the topic that uninteresting and uninspiring without
> > anything noteworthy?".
>
> I figured that this might've been it.
>
> > There were mentions of a new document for reviewers, similar to
> > SubmittingPatches is for contributors, and it would make a good
> > section to document recommended ways for reviewers to demonstrate
> > that they understand (1) the area, (2) the goal of the patches, and
> > (3) the implementation presented, better.
>
> Right, that's good feedback indeed. Ask questions, reexplain what
> happens with your own words to both double check your understanding and
> demonstrate it to others, ask for alternative ways to implement
> something. These are all ways to ACK a patch series that otherwise looks
> good to you already.
Noted. Thanks both for the feedback! :)
-Justin
prev parent reply other threads:[~2024-05-10 18:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 22:37 What's cooking in git.git (May 2024, #04; Thu, 9) Junio C Hamano
2024-05-10 1:04 ` Junio C Hamano
2024-05-10 6:32 ` Torsten Bögershausen
2024-05-10 7:54 ` Patrick Steinhardt
2024-05-10 15:35 ` Junio C Hamano
2024-05-10 16:19 ` Patrick Steinhardt
2024-05-10 18:39 ` Justin Tobler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=262znkm7vg77nzp5fadhfuqkcs6wapsuzd5dtvffoopszzoyia@uohyfeerbncl \
--to=jltobler@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).