From: Eric Sunshine <sunshine@sunshineco.com>
To: Ilya Kulakov <kulakov.ilya@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: git-gui: Visualize * History does nothing on macOS
Date: Thu, 9 May 2024 15:05:14 -0400 [thread overview]
Message-ID: <CAPig+cS1o5bqK2Ph1fFt2wi6QaOO2=83xwoqoTLifA6z3NssXA@mail.gmail.com> (raw)
In-Reply-To: <38A18180-3CC9-411B-B5D3-36C5C32B6EE9@gmail.com>
On Thu, May 9, 2024 at 2:17 PM Ilya Kulakov <kulakov.ilya@gmail.com> wrote:
> Both "Visualize <branch>'s History" and "Visualize All Branch History" do nothing on macOS. In the terminal it logs:
>
> Error in startup script: 58:103: execution error: Not authorized to send Apple events to System Events. (-1743)
> "if {[tk windowingsystem] eq "aqua"} {
> exec osascript -e [format {
> tell application "System Events"
> set frontmost of processes ..."
> (file "/opt/homebrew/bin/gitk" line 12321)
The above is reporting that the problem is in the `gitk` script...
> The relevant code at https://github.com/git/git/blob/0f3415f1f8478b05e64db11eb8aaa2915e48fef6/git-gui/git-gui.sh#L271-L279 should not be fatal, because the permission to access "System Events" and arbitrarily manipulate windows is optional.
... but the code you cited here is the git-gui script, which does not
experience the same problem because a `catch` block is wrapped around
the `exec osascript` invocation.
A patch to fix this problem in `gitk` was posted[1] in 2018 but never
got picked up since the `gitk` maintainer seems to have disappeared.
Considering that the patch is still relevant, perhaps it might make
sense for Junio to pick it up himself and apply it to the Git tree(?).
[1]: https://lore.kernel.org/git/20180724065120.7664-1-sunshine@sunshineco.com/
prev parent reply other threads:[~2024-05-09 19:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 18:17 git-gui: Visualize * History does nothing on macOS Ilya Kulakov
2024-05-09 19:05 ` Eric Sunshine [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cS1o5bqK2Ph1fFt2wi6QaOO2=83xwoqoTLifA6z3NssXA@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kulakov.ilya@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).