From: Patrick Steinhardt <ps@pks.im>
To: "Dr. David Alan Gilbert" <dave@treblig.org>
Cc: git@vger.kernel.org, jonathantanmy@google.com, gitster@pobox.com
Subject: Re: [PATCH] fetch-pack: Remove unused struct 'loose_object_iter'
Date: Mon, 13 May 2024 12:02:58 +0200 [thread overview]
Message-ID: <ZkHlUkKtqbXSvVNS@tanuki> (raw)
In-Reply-To: <20240512005913.342287-1-dave@treblig.org>
[-- Attachment #1: Type: text/plain, Size: 457 bytes --]
On Sun, May 12, 2024 at 01:59:13AM +0100, Dr. David Alan Gilbert wrote:
Tiny nit: we don't capitalize the first letter after the colon in the
subject. I don't think this warrants a reroll of this patch though.
> 'loose_object_iter' in fetch-pack.c is unused since
> commit 97b2fa08b6b9ee3e ("fetch-pack: drop custom loose object cache")
> Remove it.
Good catch, and thanks for providing historical context. The patch looks
obviously good to me.
Patrick
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-05-13 10:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-12 0:59 [PATCH] fetch-pack: Remove unused struct 'loose_object_iter' Dr. David Alan Gilbert
2024-05-13 10:02 ` Patrick Steinhardt [this message]
2024-05-13 23:56 ` Junio C Hamano
2024-05-15 6:46 ` Jeff King
2024-05-15 10:41 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkHlUkKtqbXSvVNS@tanuki \
--to=ps@pks.im \
--cc=dave@treblig.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).