From: Junio C Hamano <gitster@pobox.com>
To: Britton Kerin <britton.kerin@gmail.com>
Cc: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Subject: Re: [PATCH v2 1/1] completion: don't complete revs when --no-format-patch
Date: Sun, 28 Apr 2024 15:55:17 -0700 [thread overview]
Message-ID: <xmqqplu92j3e.fsf@gitster.g> (raw)
In-Reply-To: <CAC4O8c88Z3ZqxH2VVaNPpEGB3moL5dJcg3cOWuLWwQ_hLrJMtA@mail.gmail.com> (Britton Kerin's message of "Wed, 14 Feb 2024 11:49:08 -0900")
Britton Kerin <britton.kerin@gmail.com> writes:
> On Wed, Feb 7, 2024 at 10:57 PM Patrick Steinhardt <ps@pks.im> wrote:
>>
>> On Mon, Jan 08, 2024 at 04:08:30PM -0900, Britton Leo Kerin wrote:
>> ...
>> While this second hunk here makes perfect sense to me, there is no
>> explanation why we need to change `__git_find_last_on_cmdline ()`. It's
>> already used with "--guess --no-guess" in another place, so I would
>> think that it ought to work alright for this usecase, too. Or is it that
>> the existing callsite of this function is buggy, too? If so, we should
>> likely fix that in a separate patch together with a test.
>>
>> Also, adding a test for git-send-email that exercises this new behaviour
>> would be very much welcome, too.
>
> I'll look this one over again and add some tests eventually.
It has been a while, but is there any progress on this topic?
Thanks.
prev parent reply other threads:[~2024-04-28 22:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 9:36 [PATCH 0/1] completion: send-email: don't complete revs when --no-format-patch Britton Leo Kerin
2024-01-08 9:40 ` Dragan Simic
2024-01-08 19:34 ` Britton Kerin
2024-01-09 1:08 ` [PATCH v2 0/1] completion: " Britton Leo Kerin
[not found] ` <20240109010830.458775-1-britton.kerin@gmail.com>
2024-01-09 1:08 ` [PATCH v2 1/1] " Britton Leo Kerin
2024-02-07 22:12 ` Junio C Hamano
2024-02-08 7:57 ` Patrick Steinhardt
2024-02-14 20:49 ` Britton Kerin
2024-02-21 1:34 ` Junio C Hamano
2024-03-05 21:58 ` Junio C Hamano
2024-04-28 22:55 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqplu92j3e.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=britton.kerin@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).