From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: Glenn Washburn <development@efficientek.com>,
Vladimir 'phcoder' Serbinenko <phcoder@gmail.com>,
Daniel Axtens <dja@axtens.net>,
grub-devel@gnu.org, Yifan Zhao <zhaoyifan@sjtu.edu.cn>
Subject: Re: [PATCH v11 1/2] fs/erofs: Add support for EROFS
Date: Fri, 17 May 2024 12:45:02 +0800 [thread overview]
Message-ID: <2d862f1b-6f5f-4c1d-9850-24176f430d3a@linux.alibaba.com> (raw)
In-Reply-To: <9c07084d-f2eb-43d9-8d8a-378089cce75b@linux.alibaba.com>
Hi Daniel,
On 2024/5/17 08:34, Gao Xiang wrote:
> Hi Daniel,
>
> On 2024/5/17 05:33, Daniel Kiper wrote:
>> On Fri, May 10, 2024 at 08:52:55AM +0800, Gao Xiang wrote:
>
> ...
>
>>
>> In general patch LGTM except some nits...
>
> Thanks for the comments. Let me address them.
I've addressed your comments as a try, please kindly take
some time at the latest diff and full version...
https://lore.kernel.org/grub-devel/20240517044054.2752375-1-hsiangkao@linux.alibaba.com
Thanks,
Gao Xiang
>
>>
>> Daniel
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
next prev parent reply other threads:[~2024-05-17 4:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 0:52 [PATCH v11 0/2] Introduce EROFS support Gao Xiang
2024-05-10 0:52 ` [PATCH v11 1/2] fs/erofs: Add support for EROFS Gao Xiang
2024-05-16 21:33 ` Daniel Kiper via Grub-devel
2024-05-17 0:34 ` Gao Xiang
2024-05-17 4:45 ` Gao Xiang [this message]
2024-05-10 0:52 ` [PATCH v11 2/2] fs/erofs: Add tests for EROFS in grub-fs-tester Gao Xiang
2024-05-16 21:37 ` Daniel Kiper via Grub-devel
2024-05-17 0:34 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d862f1b-6f5f-4c1d-9850-24176f430d3a@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=daniel.kiper@oracle.com \
--cc=development@efficientek.com \
--cc=dja@axtens.net \
--cc=grub-devel@gnu.org \
--cc=phcoder@gmail.com \
--cc=zhaoyifan@sjtu.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).