Re: [PATCH 02/15] modules: strip .llvm_addrsig sections and similar.

From: "Vladimir 'phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: Peter Jones <pjones@redhat.com>,
	Jan Setje-Eilers <jan.setjeeilers@oracle.com>,
	 Mate Kukri <mate.kukri@canonical.com>
Subject: Re: [PATCH 02/15] modules: strip .llvm_addrsig sections and similar.
Date: Fri, 24 May 2024 20:42:44 +0300	[thread overview]
Message-ID: <CAEaD8JPxw-V4noAP0q0JZp5EpxRh+A23BawpoZn+zMn80ZtgLA@mail.gmail.com> (raw)
In-Reply-To: <20240524110402.203880-3-mate.kukri@canonical.com>

Reviewed-By: Vladimir Serbinenko

On Fri, May 24, 2024 at 2:06 PM Mate Kukri <mate.kukri@canonical.com> wrote:
>
> From: Peter Jones <pjones@redhat.com>
>
> Currently grub modules built with clang or gcc have several sections
> which we don't actually need or support.
>
> We already have a list of section to skip in genmod.sh, and this patch
> adds the following sections to that list (as well as a few newlines):
>
> .note.gnu.property
> .llvm*
>
> Note that the glob there won't work without a new enough linker, but the
> failure is just reversion to the status quo, so that's not a big problem.
>
> Signed-off-by: Peter Jones <pjones@redhat.com>
> (cherry picked from commit 0f66524e94d3c4f4d669d75c2122b0f1036776ea)
> Signed-off-by: Jan Setje-Eilers <jan.setjeeilers@oracle.com>
> Signed-off-by: Mate Kukri <mate.kukri@canonical.com>
> ---
>  grub-core/genmod.sh.in | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/grub-core/genmod.sh.in b/grub-core/genmod.sh.in
> index e57c4d920..337753c57 100644
> --- a/grub-core/genmod.sh.in
> +++ b/grub-core/genmod.sh.in
> @@ -57,8 +57,11 @@ if test x@TARGET_APPLE_LINKER@ != x1; then
>             @TARGET_STRIP@ --strip-unneeded \
>                 -K grub_mod_init -K grub_mod_fini \
>                 -K _grub_mod_init -K _grub_mod_fini \
> -               -R .note.gnu.gold-version -R .note.GNU-stack \
> +               -R .note.GNU-stack \
> +               -R .note.gnu.gold-version \
> +               -R .note.gnu.property \
>                 -R .gnu.build.attributes \
> +               -R '.llvm*' \
>                 -R .rel.gnu.build.attributes \
>                 -R .rela.gnu.build.attributes \
>                 -R .eh_frame -R .rela.eh_frame -R .rel.eh_frame \
> --
> 2.39.2
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Regards
Vladimir 'phcoder' Serbinenko

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel