From: Oskari Pirhonen <xxc3ncoredxx@gmail.com>
To: Oliver Steffen <osteffen@redhat.com>
Cc: grub-devel@gnu.org, Olaf Hering <olaf@aepfle.de>,
mate.kukri@canonical.com, Daniel Kiper <dkiper@net-space.pl>
Subject: Re: [RFC PATCH] Track explicit module dependencies in Makefile.core.def
Date: Thu, 22 Feb 2024 23:52:33 -0600 [thread overview]
Message-ID: <ZdgyoY6u-j3yJ1Ry@dj3ntoo> (raw)
In-Reply-To: <20240222133231.145786-1-osteffen@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 1828 bytes --]
On Thu, Feb 22, 2024 at 14:32:31 +0100, Oliver Steffen wrote:
> Add a new keyword, "depends", to the module definition syntax
> used in Makefile.core.def. This allows specifying explicit module
> dependencies together with the module definition.
>
> Do not track the "extra_deps.lst" file in the repository anymore,
> it is now auto-generated.
>
Trying to build with this, it looks like it might be broken at the site
where the extra_deps.lst is used:
1. Apply this patch in a fresh git tree
2. Revert "build: Include grub-core/extra_deps.lst in dist" (after all,
no need to include it if it's auto generated, right?)
3. Create a dist tarball
$ ./bootstrap
$ mkdir compile
$ cd compile
$ ../configure
$ make dist
4. Unpack tarball (eg, into /tmp)
5. Try to build from the tarball
$ cd /tmp/grub
$ mkdir compile
$ cd compile
$ ../configure --with-platform=efi
$ make
...
cat kernel_syms.lst ../../grub-core/extra_deps.lst > syminfo.lst.new
cat: ../../grub-core/extra_deps.lst: No such file or directory
make[3]: *** [Makefile:51281: syminfo.lst] Error 1
make[3]: Leaving directory '/tmp/grub-2.13/compile/grub-core'
make[2]: *** [Makefile:28866: all] Error 2
make[2]: Leaving directory '/tmp/grub-2.13/compile/grub-core'
make[1]: *** [Makefile:12131: all-recursive] Error 1
make[1]: Leaving directory '/tmp/grub-2.13/compile'
make: *** [Makefile:3958: all] Error 2
The file with the correct contents does get generated into grub-core/,
but if I'm understanding the output correctly, it's trying to grab
extra_deps.lst from outside the compile/ subdirectory.
- Oskari
> Make use of this new keyword in the bli module definition.
>
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 141 bytes --]
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
prev parent reply other threads:[~2024-02-23 5:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 13:32 [RFC PATCH] Track explicit module dependencies in Makefile.core.def Oliver Steffen
2024-02-22 14:13 ` Daniel Kiper
2024-02-23 5:52 ` Oskari Pirhonen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdgyoY6u-j3yJ1Ry@dj3ntoo \
--to=xxc3ncoredxx@gmail.com \
--cc=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
--cc=mate.kukri@canonical.com \
--cc=olaf@aepfle.de \
--cc=osteffen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).