From: Jeff Garzik <jeff@garzik.org>
To: hail-devel@vger.kernel.org
Subject: [PATCH] tabled/storparse: <Type> clause went away
Date: Fri, 5 Mar 2010 10:20:44 -0500 [thread overview]
Message-ID: <20100305152044.GA13012@havoc.gtf.org> (raw)
Note we need a flag at the tabled config level, to indicate whether or
not SSL should be used.
As of this commit (and related chunkd changes), encryption will be
disabled by default, with no way to enable it in tabled.
I think this makes much more sense anyway, because it is silly (and
unlikely) to use encryption or not, depending on which chunkd you
connect to.
commit e350f3a2b28ce76391f5494ab8d810407cd9a137
Author: Jeff Garzik <jeff@garzik.org>
Date: Fri Mar 5 10:10:15 2010 -0500
tabled: chunkd no longer supplies a <Type> clause for encryption
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
diff --git a/server/storparse.c b/server/storparse.c
index 17b913b..5ed15ea 100644
--- a/server/storparse.c
+++ b/server/storparse.c
@@ -266,24 +266,6 @@ static void cfg_elm_end (GMarkupParseContext *context,
cc->text = NULL;
}
- else if (!strcmp(element_name, "Type")) {
- if (!cc->text) {
- applog(LOG_WARNING,
- "%s: Type element empty", cc->fname);
- return;
- }
-
- if (!strcmp(cc->text, "chunk")) {
- ;
- } else if (!strcmp(cc->text, "chunk-ssl")) {
- cc->stor_encrypt = true;
- } else {
- applog(LOG_WARNING, "%s: Type '%s' is invalid",
- cc->fname, cc->text);
- return;
- }
- }
-
else if (!strcmp(element_name, "Port")) {
if (!cc->text) {
applog(LOG_WARNING, "Port element empty");
reply other threads:[~2010-03-05 15:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100305152044.GA13012@havoc.gtf.org \
--to=jeff@garzik.org \
--cc=hail-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).