* [Intel-gfx] [PATCH v3] drm/i915/pxp: Add drm_dbgs for critical PXP events.
@ 2023-09-15 20:15 Alan Previn
2023-09-15 20:25 ` Teres Alexis, Alan Previn
` (6 more replies)
0 siblings, 7 replies; 9+ messages in thread
From: Alan Previn @ 2023-09-15 20:15 UTC (permalink / raw
To: intel-gfx; +Cc: intel.com, dri-devel, Alan Previn
Debugging PXP issues can't even begin without understanding precedding
sequence of important events. Add drm_dbg into the most important PXP events.
v3 : - move gt_dbg to after mutex block in function
i915_gsc_proxy_component_bind. (Vivaik)
v2 : - remove __func__ since drm_dbg covers that (Jani).
- add timeout dbg of the restart from front-end (Alan).
Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c | 2 ++
drivers/gpu/drm/i915/pxp/intel_pxp.c | 15 ++++++++++++---
drivers/gpu/drm/i915/pxp/intel_pxp_irq.c | 4 ++--
drivers/gpu/drm/i915/pxp/intel_pxp_session.c | 6 +++++-
drivers/gpu/drm/i915/pxp/intel_pxp_types.h | 1 +
5 files changed, 22 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c b/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c
index 5f138de3c14f..40817ebcca71 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c
@@ -322,6 +322,7 @@ static int i915_gsc_proxy_component_bind(struct device *i915_kdev,
gsc->proxy.component = data;
gsc->proxy.component->mei_dev = mei_kdev;
mutex_unlock(&gsc->proxy.mutex);
+ gt_dbg(gt, "GSC proxy mei component bound\n");
return 0;
}
@@ -342,6 +343,7 @@ static void i915_gsc_proxy_component_unbind(struct device *i915_kdev,
with_intel_runtime_pm(&i915->runtime_pm, wakeref)
intel_uncore_rmw(gt->uncore, HECI_H_CSR(MTL_GSC_HECI2_BASE),
HECI_H_CSR_IE | HECI_H_CSR_RST, 0);
+ gt_dbg(gt, "GSC proxy mei component unbound\n");
}
static const struct component_ops i915_gsc_proxy_component_ops = {
diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.c b/drivers/gpu/drm/i915/pxp/intel_pxp.c
index dc327cf40b5a..e11f562b1876 100644
--- a/drivers/gpu/drm/i915/pxp/intel_pxp.c
+++ b/drivers/gpu/drm/i915/pxp/intel_pxp.c
@@ -303,6 +303,8 @@ static int __pxp_global_teardown_final(struct intel_pxp *pxp)
if (!pxp->arb_is_valid)
return 0;
+
+ drm_dbg(&pxp->ctrl_gt->i915->drm, "PXP: teardown for suspend/fini");
/*
* To ensure synchronous and coherent session teardown completion
* in response to suspend or shutdown triggers, don't use a worker.
@@ -324,6 +326,8 @@ static int __pxp_global_teardown_restart(struct intel_pxp *pxp)
if (pxp->arb_is_valid)
return 0;
+
+ drm_dbg(&pxp->ctrl_gt->i915->drm, "PXP: teardown for restart");
/*
* The arb-session is currently inactive and we are doing a reset and restart
* due to a runtime event. Use the worker that was designed for this.
@@ -332,8 +336,11 @@ static int __pxp_global_teardown_restart(struct intel_pxp *pxp)
timeout = intel_pxp_get_backend_timeout_ms(pxp);
- if (!wait_for_completion_timeout(&pxp->termination, msecs_to_jiffies(timeout)))
+ if (!wait_for_completion_timeout(&pxp->termination, msecs_to_jiffies(timeout))) {
+ drm_dbg(&pxp->ctrl_gt->i915->drm, "PXP: restart backend timed out (%d ms)",
+ timeout);
return -ETIMEDOUT;
+ }
return 0;
}
@@ -414,10 +421,12 @@ int intel_pxp_start(struct intel_pxp *pxp)
int ret = 0;
ret = intel_pxp_get_readiness_status(pxp, PXP_READINESS_TIMEOUT);
- if (ret < 0)
+ if (ret < 0) {
+ drm_dbg(&pxp->ctrl_gt->i915->drm, "PXP: tried but not-avail (%d)", ret);
return ret;
- else if (ret > 1)
+ } else if (ret > 1) {
return -EIO; /* per UAPI spec, user may retry later */
+ }
mutex_lock(&pxp->arb_mutex);
diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_irq.c b/drivers/gpu/drm/i915/pxp/intel_pxp_irq.c
index 91e9622c07d0..0637b1d36356 100644
--- a/drivers/gpu/drm/i915/pxp/intel_pxp_irq.c
+++ b/drivers/gpu/drm/i915/pxp/intel_pxp_irq.c
@@ -40,11 +40,11 @@ void intel_pxp_irq_handler(struct intel_pxp *pxp, u16 iir)
GEN12_DISPLAY_APP_TERMINATED_PER_FW_REQ_INTERRUPT)) {
/* immediately mark PXP as inactive on termination */
intel_pxp_mark_termination_in_progress(pxp);
- pxp->session_events |= PXP_TERMINATION_REQUEST | PXP_INVAL_REQUIRED;
+ pxp->session_events |= PXP_TERMINATION_REQUEST | PXP_INVAL_REQUIRED | PXP_EVENT_TYPE_IRQ;
}
if (iir & GEN12_DISPLAY_STATE_RESET_COMPLETE_INTERRUPT)
- pxp->session_events |= PXP_TERMINATION_COMPLETE;
+ pxp->session_events |= PXP_TERMINATION_COMPLETE | PXP_EVENT_TYPE_IRQ;
if (pxp->session_events)
queue_work(system_unbound_wq, &pxp->session_work);
diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_session.c b/drivers/gpu/drm/i915/pxp/intel_pxp_session.c
index 0a3e66b0265e..091c86e03d1a 100644
--- a/drivers/gpu/drm/i915/pxp/intel_pxp_session.c
+++ b/drivers/gpu/drm/i915/pxp/intel_pxp_session.c
@@ -137,8 +137,10 @@ void intel_pxp_terminate(struct intel_pxp *pxp, bool post_invalidation_needs_res
static void pxp_terminate_complete(struct intel_pxp *pxp)
{
/* Re-create the arb session after teardown handle complete */
- if (fetch_and_zero(&pxp->hw_state_invalidated))
+ if (fetch_and_zero(&pxp->hw_state_invalidated)) {
+ drm_dbg(&pxp->ctrl_gt->i915->drm, "PXP: creating arb_session after invalidation");
pxp_create_arb_session(pxp);
+ }
complete_all(&pxp->termination);
}
@@ -157,6 +159,8 @@ static void pxp_session_work(struct work_struct *work)
if (!events)
return;
+ drm_dbg(>->i915->drm, "PXP: processing event-flags 0x%08x", events);
+
if (events & PXP_INVAL_REQUIRED)
intel_pxp_invalidate(pxp);
diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_types.h b/drivers/gpu/drm/i915/pxp/intel_pxp_types.h
index 7e11fa8034b2..07864b584cf4 100644
--- a/drivers/gpu/drm/i915/pxp/intel_pxp_types.h
+++ b/drivers/gpu/drm/i915/pxp/intel_pxp_types.h
@@ -124,6 +124,7 @@ struct intel_pxp {
#define PXP_TERMINATION_REQUEST BIT(0)
#define PXP_TERMINATION_COMPLETE BIT(1)
#define PXP_INVAL_REQUIRED BIT(2)
+#define PXP_EVENT_TYPE_IRQ BIT(3)
};
#endif /* __INTEL_PXP_TYPES_H__ */
base-commit: cf1e91e884bb1113c653e654e9de1754fc1d4488
--
2.39.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH v3] drm/i915/pxp: Add drm_dbgs for critical PXP events.
2023-09-15 20:15 [Intel-gfx] [PATCH v3] drm/i915/pxp: Add drm_dbgs for critical PXP events Alan Previn
@ 2023-09-15 20:25 ` Teres Alexis, Alan Previn
2023-09-16 3:09 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (5 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Teres Alexis, Alan Previn @ 2023-09-15 20:25 UTC (permalink / raw
To: intel-gfx@lists.freedesktop.org; +Cc: dri-devel@lists.freedesktop.org
On Fri, 2023-09-15 at 13:15 -0700, Teres Alexis, Alan Previn wrote:
> Debugging PXP issues can't even begin without understanding precedding
> sequence of important events. Add drm_dbg into the most important PXP events.
>
> v3 : - move gt_dbg to after mutex block in function
> i915_gsc_proxy_component_bind. (Vivaik)
> v2 : - remove __func__ since drm_dbg covers that (Jani).
> - add timeout dbg of the restart from front-end (Alan).
>
alan:snip
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c
> @@ -322,6 +322,7 @@ static int i915_gsc_proxy_component_bind(struct device *i915_kdev,
> gsc->proxy.component = data;
> gsc->proxy.component->mei_dev = mei_kdev;
> mutex_unlock(&gsc->proxy.mutex);
> + gt_dbg(gt, "GSC proxy mei component bound\n");
forgot to include RB from Vivaik, per condition of fixing above hunk, from rev2 dri-devel https://lists.freedesktop.org/archives/dri-devel/2023-September/422858.html :
Reviewed-by: Balasubrawmanian, Vivaik <vivaik.balasubrawmanian at intel.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pxp: Add drm_dbgs for critical PXP events.
2023-09-15 20:15 [Intel-gfx] [PATCH v3] drm/i915/pxp: Add drm_dbgs for critical PXP events Alan Previn
2023-09-15 20:25 ` Teres Alexis, Alan Previn
@ 2023-09-16 3:09 ` Patchwork
2023-09-19 17:51 ` Teres Alexis, Alan Previn
2023-09-16 3:26 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
` (4 subsequent siblings)
6 siblings, 1 reply; 9+ messages in thread
From: Patchwork @ 2023-09-16 3:09 UTC (permalink / raw
To: Alan Previn; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/pxp: Add drm_dbgs for critical PXP events.
URL : https://patchwork.freedesktop.org/series/123803/
State : warning
== Summary ==
Error: dim checkpatch failed
2eab9e4e637a drm/i915/pxp: Add drm_dbgs for critical PXP events.
-:7: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#7:
sequence of important events. Add drm_dbg into the most important PXP events.
-:15: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Balasubrawmanian, Vivaik <vivaik.balasubrawmanian at intel.com>'
#15:
Reviewed-by: Balasubrawmanian, Vivaik <vivaik.balasubrawmanian at intel.com>
-:96: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#96: FILE: drivers/gpu/drm/i915/pxp/intel_pxp_irq.c:43:
+ pxp->session_events |= PXP_TERMINATION_REQUEST | PXP_INVAL_REQUIRED | PXP_EVENT_TYPE_IRQ;
total: 1 errors, 2 warnings, 0 checks, 95 lines checked
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/pxp: Add drm_dbgs for critical PXP events.
2023-09-15 20:15 [Intel-gfx] [PATCH v3] drm/i915/pxp: Add drm_dbgs for critical PXP events Alan Previn
2023-09-15 20:25 ` Teres Alexis, Alan Previn
2023-09-16 3:09 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2023-09-16 3:26 ` Patchwork
2023-09-16 7:06 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pxp: Add drm_dbgs for critical PXP events. (rev2) Patchwork
` (3 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-09-16 3:26 UTC (permalink / raw
To: Alan Previn; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4386 bytes --]
== Series Details ==
Series: drm/i915/pxp: Add drm_dbgs for critical PXP events.
URL : https://patchwork.freedesktop.org/series/123803/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13643 -> Patchwork_123803v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_123803v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_123803v1, please notify your bug team (lgci.bug.filing@intel.com) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v1/index.html
Participating hosts (40 -> 39)
------------------------------
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_123803v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@hangcheck:
- fi-skl-guc: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13643/fi-skl-guc/igt@i915_selftest@live@hangcheck.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v1/fi-skl-guc/igt@i915_selftest@live@hangcheck.html
* igt@kms_force_connector_basic@force-connector-state:
- bat-rpls-1: [PASS][3] -> [ABORT][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13643/bat-rpls-1/igt@kms_force_connector_basic@force-connector-state.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v1/bat-rpls-1/igt@kms_force_connector_basic@force-connector-state.html
Known issues
------------
Here are the changes found in Patchwork_123803v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: [PASS][5] -> [FAIL][6] ([fdo#103375])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13643/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v1/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
#### Possible fixes ####
* igt@i915_selftest@live@workarounds:
- bat-dg2-9: [DMESG-FAIL][7] ([i915#7913]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13643/bat-dg2-9/igt@i915_selftest@live@workarounds.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v1/bat-dg2-9/igt@i915_selftest@live@workarounds.html
* igt@kms_hdmi_inject@inject-audio:
- fi-kbl-guc: [FAIL][9] ([IGT#3] / [i915#6121]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13643/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v1/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html
* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
- bat-rplp-1: [ABORT][11] ([i915#8668]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13643/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v1/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#3]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/3
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[i915#6121]: https://gitlab.freedesktop.org/drm/intel/issues/6121
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
Build changes
-------------
* Linux: CI_DRM_13643 -> Patchwork_123803v1
CI-20190529: 20190529
CI_DRM_13643: dc4cd6e4e53d46211952fe7c0e408fce3e212993 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7490: 7490
Patchwork_123803v1: dc4cd6e4e53d46211952fe7c0e408fce3e212993 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
a92844da2e1d drm/i915/pxp: Add drm_dbgs for critical PXP events.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v1/index.html
[-- Attachment #2: Type: text/html, Size: 5160 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pxp: Add drm_dbgs for critical PXP events. (rev2)
2023-09-15 20:15 [Intel-gfx] [PATCH v3] drm/i915/pxp: Add drm_dbgs for critical PXP events Alan Previn
` (2 preceding siblings ...)
2023-09-16 3:26 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2023-09-16 7:06 ` Patchwork
2023-09-16 7:25 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
` (2 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-09-16 7:06 UTC (permalink / raw
To: Alan Previn; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/pxp: Add drm_dbgs for critical PXP events. (rev2)
URL : https://patchwork.freedesktop.org/series/123803/
State : warning
== Summary ==
Error: dim checkpatch failed
c206c1a93c37 drm/i915/pxp: Add drm_dbgs for critical PXP events.
-:7: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#7:
sequence of important events. Add drm_dbg into the most important PXP events.
-:15: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Balasubrawmanian, Vivaik <vivaik.balasubrawmanian at intel.com>'
#15:
Reviewed-by: Balasubrawmanian, Vivaik <vivaik.balasubrawmanian at intel.com>
-:96: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#96: FILE: drivers/gpu/drm/i915/pxp/intel_pxp_irq.c:43:
+ pxp->session_events |= PXP_TERMINATION_REQUEST | PXP_INVAL_REQUIRED | PXP_EVENT_TYPE_IRQ;
total: 1 errors, 2 warnings, 0 checks, 95 lines checked
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/pxp: Add drm_dbgs for critical PXP events. (rev2)
2023-09-15 20:15 [Intel-gfx] [PATCH v3] drm/i915/pxp: Add drm_dbgs for critical PXP events Alan Previn
` (3 preceding siblings ...)
2023-09-16 7:06 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pxp: Add drm_dbgs for critical PXP events. (rev2) Patchwork
@ 2023-09-16 7:25 ` Patchwork
2023-09-19 1:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pxp: Add drm_dbgs for critical PXP events. (rev3) Patchwork
2023-09-19 1:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
6 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-09-16 7:25 UTC (permalink / raw
To: Alan Previn; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4571 bytes --]
== Series Details ==
Series: drm/i915/pxp: Add drm_dbgs for critical PXP events. (rev2)
URL : https://patchwork.freedesktop.org/series/123803/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13643 -> Patchwork_123803v2
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_123803v2 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_123803v2, please notify your bug team (lgci.bug.filing@intel.com) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v2/index.html
Participating hosts (40 -> 39)
------------------------------
Additional (1): fi-kbl-soraka
Missing (2): bat-dg2-9 fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_123803v2:
### IGT changes ###
#### Possible regressions ####
* igt@i915_module_load@load:
- bat-mtlp-8: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13643/bat-mtlp-8/igt@i915_module_load@load.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v2/bat-mtlp-8/igt@i915_module_load@load.html
* igt@i915_selftest@live@perf:
- fi-kbl-soraka: NOTRUN -> [ABORT][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v2/fi-kbl-soraka/igt@i915_selftest@live@perf.html
Known issues
------------
Here are the changes found in Patchwork_123803v2 that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- fi-hsw-4770: [PASS][4] -> [FAIL][5] ([i915#8293])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13643/fi-hsw-4770/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v2/fi-hsw-4770/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#2190])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v2/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#4613]) +3 other tests skip
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v2/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][8] ([i915#5334] / [i915#7872])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v2/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
- fi-apl-guc: [PASS][9] -> [DMESG-FAIL][10] ([i915#5334])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13643/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v2/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][11] ([i915#1886] / [i915#7913])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v2/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@kms_dsc@dsc-basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][12] ([fdo#109271]) +9 other tests skip
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v2/fi-kbl-soraka/igt@kms_dsc@dsc-basic.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#8293]: https://gitlab.freedesktop.org/drm/intel/issues/8293
Build changes
-------------
* Linux: CI_DRM_13643 -> Patchwork_123803v2
CI-20190529: 20190529
CI_DRM_13643: dc4cd6e4e53d46211952fe7c0e408fce3e212993 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7490: 7490
Patchwork_123803v2: dc4cd6e4e53d46211952fe7c0e408fce3e212993 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
cb613145a48c drm/i915/pxp: Add drm_dbgs for critical PXP events.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v2/index.html
[-- Attachment #2: Type: text/html, Size: 5604 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pxp: Add drm_dbgs for critical PXP events. (rev3)
2023-09-15 20:15 [Intel-gfx] [PATCH v3] drm/i915/pxp: Add drm_dbgs for critical PXP events Alan Previn
` (4 preceding siblings ...)
2023-09-16 7:25 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2023-09-19 1:00 ` Patchwork
2023-09-19 1:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
6 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-09-19 1:00 UTC (permalink / raw
To: Teres Alexis, Alan Previn; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/pxp: Add drm_dbgs for critical PXP events. (rev3)
URL : https://patchwork.freedesktop.org/series/123803/
State : warning
== Summary ==
Error: dim checkpatch failed
d3dc616d2344 drm/i915/pxp: Add drm_dbgs for critical PXP events.
-:7: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#7:
sequence of important events. Add drm_dbg into the most important PXP events.
-:15: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Balasubrawmanian, Vivaik <vivaik.balasubrawmanian at intel.com>'
#15:
Reviewed-by: Balasubrawmanian, Vivaik <vivaik.balasubrawmanian at intel.com>
-:96: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#96: FILE: drivers/gpu/drm/i915/pxp/intel_pxp_irq.c:43:
+ pxp->session_events |= PXP_TERMINATION_REQUEST | PXP_INVAL_REQUIRED | PXP_EVENT_TYPE_IRQ;
total: 1 errors, 2 warnings, 0 checks, 95 lines checked
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pxp: Add drm_dbgs for critical PXP events. (rev3)
2023-09-15 20:15 [Intel-gfx] [PATCH v3] drm/i915/pxp: Add drm_dbgs for critical PXP events Alan Previn
` (5 preceding siblings ...)
2023-09-19 1:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pxp: Add drm_dbgs for critical PXP events. (rev3) Patchwork
@ 2023-09-19 1:12 ` Patchwork
6 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-09-19 1:12 UTC (permalink / raw
To: Teres Alexis, Alan Previn; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 2620 bytes --]
== Series Details ==
Series: drm/i915/pxp: Add drm_dbgs for critical PXP events. (rev3)
URL : https://patchwork.freedesktop.org/series/123803/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13651 -> Patchwork_123803v3
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v3/index.html
Participating hosts (38 -> 37)
------------------------------
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_123803v3 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s0@lmem0:
- bat-dg2-9: [PASS][1] -> [INCOMPLETE][2] ([i915#9275])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/bat-dg2-9/igt@gem_exec_suspend@basic-s0@lmem0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v3/bat-dg2-9/igt@gem_exec_suspend@basic-s0@lmem0.html
#### Possible fixes ####
* igt@i915_selftest@live@execlists:
- fi-bsw-n3050: [ABORT][3] ([i915#7913]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v3/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
* igt@kms_hdmi_inject@inject-audio:
- fi-kbl-guc: [FAIL][5] ([IGT#3] / [i915#6121]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v3/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html
[IGT#3]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/3
[i915#6121]: https://gitlab.freedesktop.org/drm/intel/issues/6121
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#9275]: https://gitlab.freedesktop.org/drm/intel/issues/9275
Build changes
-------------
* Linux: CI_DRM_13651 -> Patchwork_123803v3
CI-20190529: 20190529
CI_DRM_13651: 61b71c3f061a44a6ab1dcf756918886aa03a5480 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7493: 2517e42d612e0c1ca096acf8b5f6177f7ef4bce7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_123803v3: 61b71c3f061a44a6ab1dcf756918886aa03a5480 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
6a9f9b406f68 drm/i915/pxp: Add drm_dbgs for critical PXP events.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123803v3/index.html
[-- Attachment #2: Type: text/html, Size: 3280 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pxp: Add drm_dbgs for critical PXP events.
2023-09-16 3:09 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2023-09-19 17:51 ` Teres Alexis, Alan Previn
0 siblings, 0 replies; 9+ messages in thread
From: Teres Alexis, Alan Previn @ 2023-09-19 17:51 UTC (permalink / raw
To: intel-gfx@lists.freedesktop.org
On Sat, 2023-09-16 at 03:09 +0000, Patchwork wrote:
>
alan:snip
> 2eab9e4e637a drm/i915/pxp: Add drm_dbgs for critical PXP events.
> -:7: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
> #7:
> sequence of important events. Add drm_dbg into the most important PXP events.
>
> -:15: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Balasubrawmanian, Vivaik <vivaik.balasubrawmanian at intel.com>'
> #15:
> Reviewed-by: Balasubrawmanian, Vivaik <vivaik.balasubrawmanian at intel.com>
>
> -:96: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
> #96: FILE: drivers/gpu/drm/i915/pxp/intel_pxp_irq.c:43:
> + pxp->session_events |= PXP_TERMINATION_REQUEST | PXP_INVAL_REQUIRED | PXP_EVENT_TYPE_IRQ;
Will fix these before we merge.
...alan
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-09-19 17:51 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-15 20:15 [Intel-gfx] [PATCH v3] drm/i915/pxp: Add drm_dbgs for critical PXP events Alan Previn
2023-09-15 20:25 ` Teres Alexis, Alan Previn
2023-09-16 3:09 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2023-09-19 17:51 ` Teres Alexis, Alan Previn
2023-09-16 3:26 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-09-16 7:06 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pxp: Add drm_dbgs for critical PXP events. (rev2) Patchwork
2023-09-16 7:25 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-09-19 1:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pxp: Add drm_dbgs for critical PXP events. (rev3) Patchwork
2023-09-19 1:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).