From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Michal Wajdeczko" <michal.wajdeczko@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: ✗ CI.checkpatch: warning for drm/xe/tests: Add kunit tests for memory based interrupts
Date: Tue, 28 Apr 2026 16:33:56 -0000 [thread overview]
Message-ID: <177739403655.22199.15479444657123284094@5ab824fced77> (raw)
In-Reply-To: <20260428142722.582-1-michal.wajdeczko@intel.com>
== Series Details ==
Series: drm/xe/tests: Add kunit tests for memory based interrupts
URL : https://patchwork.freedesktop.org/series/165651/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c8c12e558adaef7a4d125d83b6e1f8824bc13b82
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 395d15296dff07c7a84870a45283aad23fa09092
Author: Michal Wajdeczko <michal.wajdeczko@intel.com>
Date: Tue Apr 28 16:27:20 2026 +0200
drm/xe/tests: Add kunit tests for memory based interrupts
Add basic kunit tests for the memory based interrupts. For maximum
coverage, we will use non-real device definition with custom mix of
GT IPs that are defined with the largest number of engines.
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
+ /mt/dim checkpatch e066eb26712bca7174e694a358351c50a38661d6 drm-intel
4da73b511746 drm/xe/ggtt: Rename parameter name in xe_ggtt_init_kunit()
6a2097147607 drm/xe/guc: Allow to replace xe_guc_irq_handler() with stub
b4e281e17701 drm/xe/hwe: Allow to replace xe_hw_engine_handle_irq() with stub
f38eaa083eb8 drm/xe/mmio: Allow to replace xe_mmio_read32|write32() with stub
4b58aedae808 drm/xe/kunit: Promote GGTT initialization to test_init() helper
b11451f01e7e drm/xe/kunit: Promote fake BO activation to test_init() helper
ce476abd7a09 drm/xe/kunit: Activate empty MMIO stubs in test_init()
af6a5b30ac29 drm/xe/memirq: Make page layout macros private
584f5e2134a6 drm/xe/memirq: Introduce helper to calculate source page offset
6fe6df8e9814 drm/xe/memirq: Introduce helper to calculate status vector offset
a36bf197d3aa drm/xe/memirq: Refactor xe_memirq_hwe_handler
5fa2e2e00719 drm/xe/memirq: Dump additional source pages if MSI-X
395d15296dff drm/xe/tests: Add kunit tests for memory based interrupts
-:13: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#13:
new file mode 100644
-:213: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'n' - possible side-effects?
#213: FILE: drivers/gpu/drm/xe/tests/xe_memirq_kunit.c:196:
+#define INTR_bcs(n) ((((n) < 8) ? INTR_BCS(n) : INTR_BCS8) + BUILD_BUG_ON_ZERO((n) > 8))
-:215: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'IIR' - possible side-effects?
#215: FILE: drivers/gpu/drm/xe/tests/xe_memirq_kunit.c:198:
+#define MAKE_MEMIRQ_TEST_PARAM(NAME, SRC, S0, INST, IIR, ...) { \
+ .name = (NAME), \
+ .source = ilog2(INTR_##SRC) __VA_ARGS__, \
+ .source0 = ilog2(INTR_##S0) __VA_ARGS__, \
+ .instance = (INST), \
+ .status = ilog2(IIR), \
+ .iir = (IIR), \
+}
-:224: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'GUC' - possible side-effects?
#224: FILE: drivers/gpu/drm/xe/tests/xe_memirq_kunit.c:207:
+#define MAKE_MEMIRQ_TEST_PARAM_GUC(GUC, IIR, ...) \
+ MAKE_MEMIRQ_TEST_PARAM(#GUC " " #IIR, GUC, GUC, 0, GUC_INTR_##IIR)
-:227: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ENG' - possible side-effects?
#227: FILE: drivers/gpu/drm/xe/tests/xe_memirq_kunit.c:210:
+#define MAKE_MEMIRQ_TEST_PARAM_HWE(ENG, INST, IIR, ...) \
+ MAKE_MEMIRQ_TEST_PARAM(#ENG #INST " " #IIR, ENG(INST), ENG(0), (INST), \
+ GT_##IIR, ##__VA_ARGS__)
-:227: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'INST' - possible side-effects?
#227: FILE: drivers/gpu/drm/xe/tests/xe_memirq_kunit.c:210:
+#define MAKE_MEMIRQ_TEST_PARAM_HWE(ENG, INST, IIR, ...) \
+ MAKE_MEMIRQ_TEST_PARAM(#ENG #INST " " #IIR, ENG(INST), ENG(0), (INST), \
+ GT_##IIR, ##__VA_ARGS__)
-:253: CHECK:SPACING: spaces preferred around that '+' (ctx:WxV)
#253: FILE: drivers/gpu/drm/xe/tests/xe_memirq_kunit.c:236:
+ MAKE_MEMIRQ_TEST_PARAM_HWE(VCS, 0, MI_USER_INTERRUPT, +32),
^
-:254: CHECK:SPACING: spaces preferred around that '+' (ctx:WxV)
#254: FILE: drivers/gpu/drm/xe/tests/xe_memirq_kunit.c:237:
+ MAKE_MEMIRQ_TEST_PARAM_HWE(VCS, 1, MI_USER_INTERRUPT, +32),
^
-:255: CHECK:SPACING: spaces preferred around that '+' (ctx:WxV)
#255: FILE: drivers/gpu/drm/xe/tests/xe_memirq_kunit.c:238:
+ MAKE_MEMIRQ_TEST_PARAM_HWE(VCS, 2, MI_USER_INTERRUPT, +32),
^
-:256: CHECK:SPACING: spaces preferred around that '+' (ctx:WxV)
#256: FILE: drivers/gpu/drm/xe/tests/xe_memirq_kunit.c:239:
+ MAKE_MEMIRQ_TEST_PARAM_HWE(VCS, 3, MI_USER_INTERRUPT, +32),
^
-:257: CHECK:SPACING: spaces preferred around that '+' (ctx:WxV)
#257: FILE: drivers/gpu/drm/xe/tests/xe_memirq_kunit.c:240:
+ MAKE_MEMIRQ_TEST_PARAM_HWE(VCS, 4, MI_USER_INTERRUPT, +32),
^
-:258: CHECK:SPACING: spaces preferred around that '+' (ctx:WxV)
#258: FILE: drivers/gpu/drm/xe/tests/xe_memirq_kunit.c:241:
+ MAKE_MEMIRQ_TEST_PARAM_HWE(VCS, 5, MI_USER_INTERRUPT, +32),
^
-:259: CHECK:SPACING: spaces preferred around that '+' (ctx:WxV)
#259: FILE: drivers/gpu/drm/xe/tests/xe_memirq_kunit.c:242:
+ MAKE_MEMIRQ_TEST_PARAM_HWE(VCS, 6, MI_USER_INTERRUPT, +32),
^
-:260: CHECK:SPACING: spaces preferred around that '+' (ctx:WxV)
#260: FILE: drivers/gpu/drm/xe/tests/xe_memirq_kunit.c:243:
+ MAKE_MEMIRQ_TEST_PARAM_HWE(VCS, 7, MI_USER_INTERRUPT, +32),
^
-:261: CHECK:SPACING: spaces preferred around that '+' (ctx:WxV)
#261: FILE: drivers/gpu/drm/xe/tests/xe_memirq_kunit.c:244:
+ MAKE_MEMIRQ_TEST_PARAM_HWE(VECS, 0, MI_USER_INTERRUPT, +32),
^
-:262: CHECK:SPACING: spaces preferred around that '+' (ctx:WxV)
#262: FILE: drivers/gpu/drm/xe/tests/xe_memirq_kunit.c:245:
+ MAKE_MEMIRQ_TEST_PARAM_HWE(VECS, 1, MI_USER_INTERRUPT, +32),
^
-:263: CHECK:SPACING: spaces preferred around that '+' (ctx:WxV)
#263: FILE: drivers/gpu/drm/xe/tests/xe_memirq_kunit.c:246:
+ MAKE_MEMIRQ_TEST_PARAM_HWE(VECS, 2, MI_USER_INTERRUPT, +32),
^
-:264: CHECK:SPACING: spaces preferred around that '+' (ctx:WxV)
#264: FILE: drivers/gpu/drm/xe/tests/xe_memirq_kunit.c:247:
+ MAKE_MEMIRQ_TEST_PARAM_HWE(VECS, 3, MI_USER_INTERRUPT, +32),
^
total: 0 errors, 1 warnings, 17 checks, 283 lines checked
next prev parent reply other threads:[~2026-04-28 16:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 14:27 [PATCH 00/13] drm/xe/tests: Add kunit tests for memory based interrupts Michal Wajdeczko
2026-04-28 14:27 ` [PATCH 01/13] drm/xe/ggtt: Rename parameter name in xe_ggtt_init_kunit() Michal Wajdeczko
2026-04-29 20:29 ` Summers, Stuart
2026-04-30 8:32 ` Jani Nikula
2026-04-30 21:50 ` Summers, Stuart
2026-04-28 14:27 ` [PATCH 02/13] drm/xe/guc: Allow to replace xe_guc_irq_handler() with stub Michal Wajdeczko
2026-04-30 5:44 ` K V P, Satyanarayana
2026-04-28 14:27 ` [PATCH 03/13] drm/xe/hwe: Allow to replace xe_hw_engine_handle_irq() " Michal Wajdeczko
2026-04-30 5:47 ` K V P, Satyanarayana
2026-04-28 14:27 ` [PATCH 04/13] drm/xe/mmio: Allow to replace xe_mmio_read32|write32() " Michal Wajdeczko
2026-04-30 5:48 ` K V P, Satyanarayana
2026-04-28 14:27 ` [PATCH 05/13] drm/xe/kunit: Promote GGTT initialization to test_init() helper Michal Wajdeczko
2026-04-28 14:27 ` [PATCH 06/13] drm/xe/kunit: Promote fake BO activation " Michal Wajdeczko
2026-04-28 14:27 ` [PATCH 07/13] drm/xe/kunit: Activate empty MMIO stubs in test_init() Michal Wajdeczko
2026-04-28 14:27 ` [PATCH 08/13] drm/xe/memirq: Make page layout macros private Michal Wajdeczko
2026-05-05 7:54 ` Levi, Ilia
2026-04-28 14:27 ` [PATCH 09/13] drm/xe/memirq: Introduce helper to calculate source page offset Michal Wajdeczko
2026-05-05 8:27 ` Levi, Ilia
2026-04-28 14:27 ` [PATCH 10/13] drm/xe/memirq: Introduce helper to calculate status vector offset Michal Wajdeczko
2026-05-05 12:40 ` Levi, Ilia
2026-04-28 14:27 ` [PATCH 11/13] drm/xe/memirq: Refactor xe_memirq_hwe_handler Michal Wajdeczko
2026-05-05 12:46 ` Levi, Ilia
2026-04-28 14:27 ` [PATCH 12/13] drm/xe/memirq: Dump additional source pages if MSI-X Michal Wajdeczko
2026-05-05 13:12 ` Levi, Ilia
2026-04-28 14:27 ` [PATCH 13/13] drm/xe/tests: Add kunit tests for memory based interrupts Michal Wajdeczko
2026-04-28 16:33 ` Patchwork [this message]
2026-04-28 16:35 ` ✓ CI.KUnit: success for " Patchwork
2026-04-28 17:43 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-29 5:04 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177739403655.22199.15479444657123284094@5ab824fced77 \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).