From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Jani Nikula" <jani.nikula@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: ✗ CI.checkpatch: warning for drm/i915/display: start switching to display specific reg types (rev2)
Date: Tue, 05 May 2026 09:36:10 -0000 [thread overview]
Message-ID: <177797377010.38316.2615901012648694488@5ab824fced77> (raw)
In-Reply-To: <cover.1777972548.git.jani.nikula@intel.com>
== Series Details ==
Series: drm/i915/display: start switching to display specific reg types (rev2)
URL : https://patchwork.freedesktop.org/series/164540/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c8c12e558adaef7a4d125d83b6e1f8824bc13b82
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 42c553cadf4ecc1107e6b9e2b12063d0b811b139
Author: Jani Nikula <jani.nikula@intel.com>
Date: Tue May 5 12:16:48 2026 +0300
drm/i915/display: define and use intel_reg_{offset, equal, valid}() helpers
Add display specific helpers for getting the register offset, checking
for equality and validity. Add them as static inlines for increased type
safety.
Reviewed-by: Michał Grzelak <michal.grzelak@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
+ /mt/dim checkpatch fa7a3955d5aca4e8e7299ee765637de39009850e drm-intel
a21795ae8e8b drm/i915/display: add typedef for intel_reg_t and use it
-:813: WARNING:NEW_TYPEDEFS: do not add new typedefs
#813: FILE: drivers/gpu/drm/i915/display/intel_display_reg_defs.h:11:
+typedef i915_reg_t intel_reg_t;
total: 0 errors, 1 warnings, 0 checks, 1982 lines checked
5274071c22cf drm/i915/display: add struct intel_irq_regs and use it
-:96: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects?
#96: FILE: drivers/gpu/drm/i915/display/intel_display_regs.h:1410:
+#define GEN8_DE_PIPE_IRQ_REGS(pipe) INTEL_IRQ_REGS(GEN8_DE_PIPE_IMR(pipe), \
+ GEN8_DE_PIPE_IER(pipe), \
+ GEN8_DE_PIPE_IIR(pipe))
total: 0 errors, 0 warnings, 1 checks, 128 lines checked
b5e25ef972c4 drm/i915/display: add struct intel_error_regs and use it
42c553cadf4e drm/i915/display: define and use intel_reg_{offset, equal, valid}() helpers
-:164: CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#164: FILE: drivers/gpu/drm/i915/display/intel_dmc.c:1153:
+ i+1, intel_reg_offset(dmc_info->mmioaddr[i+1]),
^
-:164: CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#164: FILE: drivers/gpu/drm/i915/display/intel_dmc.c:1153:
+ i+1, intel_reg_offset(dmc_info->mmioaddr[i+1]),
^
total: 0 errors, 0 warnings, 2 checks, 246 lines checked
next prev parent reply other threads:[~2026-05-05 9:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 9:16 [RESEND 0/4] drm/i915/display: start switching to display specific reg types Jani Nikula
2026-05-05 9:16 ` [RESEND 1/4] drm/i915/display: add typedef for intel_reg_t and use it Jani Nikula
2026-05-05 9:16 ` [RESEND 2/4] drm/i915/display: add struct intel_irq_regs " Jani Nikula
2026-05-05 9:16 ` [RESEND 3/4] drm/i915/display: add struct intel_error_regs " Jani Nikula
2026-05-05 9:16 ` [RESEND 4/4] drm/i915/display: define and use intel_reg_{offset, equal, valid}() helpers Jani Nikula
2026-05-05 9:36 ` Patchwork [this message]
2026-05-05 9:37 ` ✓ CI.KUnit: success for drm/i915/display: start switching to display specific reg types (rev2) Patchwork
2026-05-05 11:00 ` ✓ Xe.CI.BAT: " Patchwork
2026-05-05 19:41 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-05-08 11:29 ` [RESEND 0/4] drm/i915/display: start switching to display specific reg types Jani Nikula
2026-05-13 12:31 ` Ville Syrjälä
2026-05-13 13:50 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177797377010.38316.2615901012648694488@5ab824fced77 \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).