From: Patchwork <patchwork@emeril.freedesktop.org>
To: mpenttil@redhat.com
Cc: intel-xe@lists.freedesktop.org
Subject: ✗ CI.checkpatch: warning for Migrate on fault for device pages (rev2)
Date: Tue, 05 May 2026 18:50:57 -0000 [thread overview]
Message-ID: <177800705789.40958.13381685956626687291@5ab824fced77> (raw)
In-Reply-To: <20260505184421.2324798-1-mpenttil@redhat.com>
== Series Details ==
Series: Migrate on fault for device pages (rev2)
URL : https://patchwork.freedesktop.org/series/165953/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c8c12e558adaef7a4d125d83b6e1f8824bc13b82
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 323748c3bffcdd9e173e14479fd0f98e2438df74
Author: Mika Penttilä <mpenttil@redhat.com>
Date: Tue May 5 21:44:21 2026 +0300
lib/test_hmm:: add a new testcase for the migrate on fault
Enhance the hmm test driver (lib/test_hmm) with migrate on fault case.
Cc: David Hildenbrand <david@kernel.org>
Cc: Jason Gunthorpe <jgg@nvidia.com>
Cc: Leon Romanovsky <leonro@nvidia.com>
Cc: Alistair Popple <apopple@nvidia.com>
Cc: Balbir Singh <balbirs@nvidia.com>
Cc: Zi Yan <ziy@nvidia.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Marco Pagani <marpagan@redhat.com>
Signed-off-by: Mika Penttilä <mpenttil@redhat.com>
+ /mt/dim checkpatch e782e6a579775723266be631e06276d43aa7a907 drm-intel
729d3c89a1aa mm/Kconfig: changes for migrate on fault for device pages
a5466856c900 mm: Add helper to convert HMM pfn to migrate pfn
-:174: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#174: FILE: mm/migrate_device.c:1543:
+
+}
total: 0 errors, 0 warnings, 1 checks, 132 lines checked
928a21744ab2 mm/hmm: do the plumbing for HMM to participate in migration
-:127: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#127: FILE: mm/hmm.c:56:
+ spinlock_t *ptl;
-:130: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'hmm_vma_walk' may be better as '(hmm_vma_walk)' to avoid precedence issues
#130: FILE: mm/hmm.c:59:
+#define HMM_ASSERT_PTE_LOCKED(hmm_vma_walk, locked) \
+ WARN_ON_ONCE(hmm_vma_walk->ptelocked != locked)
-:130: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'locked' may be better as '(locked)' to avoid precedence issues
#130: FILE: mm/hmm.c:59:
+#define HMM_ASSERT_PTE_LOCKED(hmm_vma_walk, locked) \
+ WARN_ON_ONCE(hmm_vma_walk->ptelocked != locked)
-:133: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'hmm_vma_walk' may be better as '(hmm_vma_walk)' to avoid precedence issues
#133: FILE: mm/hmm.c:62:
+#define HMM_ASSERT_PMD_LOCKED(hmm_vma_walk, locked) \
+ WARN_ON_ONCE(hmm_vma_walk->pmdlocked != locked)
-:133: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'locked' may be better as '(locked)' to avoid precedence issues
#133: FILE: mm/hmm.c:62:
+#define HMM_ASSERT_PMD_LOCKED(hmm_vma_walk, locked) \
+ WARN_ON_ONCE(hmm_vma_walk->pmdlocked != locked)
-:136: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hmm_vma_walk' - possible side-effects?
#136: FILE: mm/hmm.c:65:
+#define HMM_ASSERT_UNLOCKED(hmm_vma_walk) \
+ WARN_ON_ONCE(hmm_vma_walk->ptelocked || \
+ hmm_vma_walk->pmdlocked)
-:136: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'hmm_vma_walk' may be better as '(hmm_vma_walk)' to avoid precedence issues
#136: FILE: mm/hmm.c:65:
+#define HMM_ASSERT_UNLOCKED(hmm_vma_walk) \
+ WARN_ON_ONCE(hmm_vma_walk->ptelocked || \
+ hmm_vma_walk->pmdlocked)
-:233: CHECK:BRACES: braces {} should be used on all arms of this statement
#233: FILE: mm/hmm.c:357:
+ if (!hmm_select_migrate(range)) {
[...]
+ } else
[...]
-:239: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#239: FILE: mm/hmm.c:363:
+ return -EBUSY;
+ } else
-:239: CHECK:BRACES: Unbalanced braces around else statement
#239: FILE: mm/hmm.c:363:
+ } else
-:246: CHECK:BRACES: braces {} should be used on all arms of this statement
#246: FILE: mm/hmm.c:369:
+ if (hmm_vma_walk->ptelocked) {
[...]
+ } else
[...]
-:249: CHECK:BRACES: Unbalanced braces around else statement
#249: FILE: mm/hmm.c:372:
+ } else
-:260: CHECK:BRACES: braces {} should be used on all arms of this statement
#260: FILE: mm/hmm.c:391:
+ if (hmm_vma_walk->ptelocked) {
[...]
+ } else
[...]
-:263: CHECK:BRACES: Unbalanced braces around else statement
#263: FILE: mm/hmm.c:394:
+ } else
-:274: CHECK:BRACES: braces {} should be used on all arms of this statement
#274: FILE: mm/hmm.c:409:
+ if (hmm_vma_walk->ptelocked) {
[...]
+ } else
[...]
-:277: CHECK:BRACES: Unbalanced braces around else statement
#277: FILE: mm/hmm.c:412:
+ } else
-:287: CHECK:BRACES: braces {} should be used on all arms of this statement
#287: FILE: mm/hmm.c:457:
+ if (softleaf_is_device_private(entry)) {
[...]
else
[...]
-:383: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hmm_vma_walk->vma != walk->vma'
#383: FILE: mm/hmm.c:550:
+ if (hmm_vma_walk->vma && (hmm_vma_walk->vma != walk->vma))
-:432: CHECK:BRACES: braces {} should be used on all arms of this statement
#432: FILE: mm/hmm.c:594:
+ if (minfo) {
[...]
+ } else
[...]
-:436: CHECK:BRACES: Unbalanced braces around else statement
#436: FILE: mm/hmm.c:598:
+ } else
-:470: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#470: FILE: mm/hmm.c:631:
+ if (pmd_trans_huge(pmd) || !pmd_present(pmd)) {
+
-:485: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#485: FILE: mm/hmm.c:646:
+ if (pmd_trans_huge(pmd)) {
+
-:554: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#554: FILE: mm/hmm.c:696:
+ }
-:572: CHECK:BRACES: braces {} should be used on all arms of this statement
#572: FILE: mm/hmm.c:715:
+ if (minfo) {
[...]
+ } else
[...]
-:576: CHECK:BRACES: Unbalanced braces around else statement
#576: FILE: mm/hmm.c:719:
+ } else
-:603: CHECK:BRACES: braces {} should be used on all arms of this statement
#603: FILE: mm/hmm.c:743:
+ if (hmm_vma_walk->ptelocked) {
[...]
+ } else
[...]
-:606: CHECK:BRACES: Unbalanced braces around else statement
#606: FILE: mm/hmm.c:746:
+ } else
-:682: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#682: FILE: mm/hmm.c:980:
+ if (is_fault_path && mmu_interval_check_retry(range->notifier,
+ range->notifier_seq)) {
total: 0 errors, 1 warnings, 27 checks, 648 lines checked
b72d51f7d004 mm: setup device page migration in HMM pagewalk
-:195: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#195: FILE: mm/hmm.c:612:
+ IS_ALIGNED(end, HPAGE_PMD_SIZE))) {
+
-:219: CHECK:LINE_SPACING: Please don't use multiple blank lines
#219: FILE: mm/hmm.c:636:
+
+
-:382: CHECK:BRACES: braces {} should be used on all arms of this statement
#382: FILE: mm/hmm.c:796:
+ if (fault_folio == folio || folio_trylock(folio)) {
[...]
+ } else
[...]
-:439: CHECK:BRACES: Unbalanced braces around else statement
#439: FILE: mm/hmm.c:853:
+ } else
-:458: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#458: FILE: mm/hmm.c:869:
+ spinlock_t *ptl;
-:480: CHECK:BRACES: braces {} should be used on all arms of this statement
#480: FILE: mm/hmm.c:891:
+ if (folio != fault_folio) {
[...]
+ } else
[...]
-:486: CHECK:BRACES: Unbalanced braces around else statement
#486: FILE: mm/hmm.c:897:
+ } else
-:495: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#495: FILE: mm/hmm.c:906:
+
+ }
total: 0 errors, 0 warnings, 8 checks, 1062 lines checked
323748c3bffc lib/test_hmm:: add a new testcase for the migrate on fault
-:124: CHECK:LINE_SPACING: Please don't use multiple blank lines
#124: FILE: lib/test_hmm.c:1349:
+
+
-:197: CHECK:LINE_SPACING: Please don't use multiple blank lines
#197: FILE: tools/testing/selftests/mm/hmm-tests.c:995:
+
total: 0 errors, 0 warnings, 2 checks, 208 lines checked
next prev parent reply other threads:[~2026-05-05 18:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 18:44 [PATCH v10 0/5] Migrate on fault for device pages mpenttil
2026-05-05 18:44 ` [PATCH v10 1/5] mm/Kconfig: changes for migrate " mpenttil
2026-05-05 18:44 ` [PATCH v10 2/5] mm: Add helper to convert HMM pfn to migrate pfn mpenttil
2026-05-12 11:43 ` David Hildenbrand (Arm)
2026-05-12 12:08 ` Mika Penttilä
2026-05-12 12:44 ` David Hildenbrand (Arm)
2026-05-05 18:44 ` [PATCH v10 3/5] mm/hmm: do the plumbing for HMM to participate in migration mpenttil
2026-05-05 18:44 ` [PATCH v10 4/5] mm: setup device page migration in HMM pagewalk mpenttil
2026-05-05 18:44 ` [PATCH v10 5/5] lib/test_hmm:: add a new testcase for the migrate on fault mpenttil
2026-05-05 18:50 ` Patchwork [this message]
2026-05-05 18:52 ` ✓ CI.KUnit: success for Migrate on fault for device pages (rev2) Patchwork
2026-05-15 3:07 ` [PATCH v10 0/5] Migrate on fault for device pages Balbir Singh
2026-05-15 4:05 ` Mika Penttilä
2026-05-15 7:33 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177800705789.40958.13381685956626687291@5ab824fced77 \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=mpenttil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).