From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
"Kahola, Mika" <mika.kahola@intel.com>,
"jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v2] drm/i915/psr: Disable PSR2 on Xiaomi Book Pro 14 2026 as a quirk
Date: Thu, 30 Apr 2026 11:00:01 +0000 [thread overview]
Message-ID: <6b626e3431b1e099c13b729be5fd8d89a962a1da.camel@intel.com> (raw)
In-Reply-To: <DS4PPF69154114F3775436040F9F33D4D29EF202@DS4PPF69154114F.namprd11.prod.outlook.com>
On Fri, 2026-04-17 at 10:59 +0000, Kahola, Mika wrote:
> > -----Original Message-----
> > From: Intel-xe <intel-xe-bounces@lists.freedesktop.org> On Behalf
> > Of Jani Nikula
> > Sent: Friday, 17 April 2026 13.33
> > To: Hogander, Jouni <jouni.hogander@intel.com>;
> > intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org
> > Cc: Hogander, Jouni <jouni.hogander@intel.com>
> > Subject: Re: [PATCH v2] drm/i915/psr: Disable PSR2 on Xiaomi Book
> > Pro 14 2026 as a quirk
> >
> > On Fri, 17 Apr 2026, Jouni Högander <jouni.hogander@intel.com>
> > wrote:
> > > Add new quirk (QUIRK_DISABLE_PSR2) for disabling PSR2 as a quirk
> > > for
> > > problematic setups. Apply this newly added quirk on Xiaomi Book
> > > Pro 14
> > > 2026.
> > >
> > > v2: logging adjusted
> > >
> > > Closes:
> > > https://gitlab.freedesktop.org/drm/xe/kernel/-/work_items/7677
>
> Reviewed-by: Mika Kahola <mika.kahola@intel.com>
>
> > > Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> >
> > Acked-by: Jani Nikula <jani.nikula@intel.com>
Thank you Jani and Mika for checking my patch. This is now pushed to
drm-intel-next.
BR,
Jouni Högander
> >
> > > ---
> > > drivers/gpu/drm/i915/display/intel_psr.c | 3 +++
> > > drivers/gpu/drm/i915/display/intel_quirks.c | 9 +++++++++
> > > drivers/gpu/drm/i915/display/intel_quirks.h | 1 +
> > > 3 files changed, 13 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > > b/drivers/gpu/drm/i915/display/intel_psr.c
> > > index 63c19958a9e3..d1bae7d32617 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > > @@ -695,6 +695,9 @@ static void _psr_init_dpcd(struct intel_dp
> > > *intel_dp, struct intel_connector *co
> > >
> > > connector->dp.psr_caps.sync_latency =
> > > intel_dp_get_sink_sync_latency(intel_dp);
> > >
> > > + if (intel_has_quirk(display, QUIRK_DISABLE_PSR2))
> > > + return;
> > > +
> > > if (DISPLAY_VER(display) >= 9 &&
> > > connector->dp.psr_caps.dpcd[0] >=
> > > DP_PSR2_WITH_Y_COORD_IS_SUPPORTED) {
> > > bool y_req = connector->dp.psr_caps.dpcd[1] &
> > > diff --git
> > > a/drivers/gpu/drm/i915/display/intel_quirks.c
> > > b/drivers/gpu/drm/i915/display/intel_quirks.c
> > > index 883f297d4b83..d1c428eeb608 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_quirks.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_quirks.c
> > > @@ -94,6 +94,12 @@ static void
> > > quirk_disable_edp_panel_replay(struct intel_dp *intel_dp)
> > > drm_info(display->drm, "Applying disable Panel Replay
> > > quirk\n"); }
> > >
> > > +static void quirk_disable_psr2(struct intel_display *display) {
> > > + intel_set_quirk(display, QUIRK_DISABLE_PSR2);
> > > + drm_info(display->drm, "PSR2 support not currently
> > > available for
> > > +this setup, applying disable PSR2 quirk\n"); }
> > > +
> > > struct intel_quirk {
> > > int device;
> > > int subsystem_vendor;
> > > @@ -250,6 +256,9 @@ static struct intel_quirk intel_quirks[] = {
> > >
> > > /* Dell XPS 13 7390 2-in-1 */
> > > { 0x8a52, 0x1028, 0x08b0, quirk_edp_limit_rate_hbr2 },
> > > +
> > > + /* Xiaomi Book Pro 14 2026 */
> > > + { 0xb081, 0x1d72, 0x2424, quirk_disable_psr2 },
> > > };
> > >
> > > static const struct intel_dpcd_quirk intel_dpcd_quirks[] = {
> > > diff
> > > --git a/drivers/gpu/drm/i915/display/intel_quirks.h
> > > b/drivers/gpu/drm/i915/display/intel_quirks.h
> > > index 83214eb94b0c..970a4fe52faf 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_quirks.h
> > > +++ b/drivers/gpu/drm/i915/display/intel_quirks.h
> > > @@ -22,6 +22,7 @@ enum intel_quirk_id {
> > > QUIRK_FW_SYNC_LEN,
> > > QUIRK_EDP_LIMIT_RATE_HBR2,
> > > QUIRK_DISABLE_EDP_PANEL_REPLAY,
> > > + QUIRK_DISABLE_PSR2,
> > > };
> > >
> > > void intel_init_quirks(struct intel_display *display);
> >
> > --
> > Jani Nikula, Intel
next prev parent reply other threads:[~2026-04-30 11:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 10:23 [PATCH v2] drm/i915/psr: Disable PSR2 on Xiaomi Book Pro 14 2026 as a quirk Jouni Högander
2026-04-17 10:32 ` Jani Nikula
2026-04-17 10:59 ` Kahola, Mika
2026-04-30 11:00 ` Hogander, Jouni [this message]
2026-04-20 14:47 ` ✓ CI.KUnit: success for drm/i915/psr: Disable PSR2 on Xiaomi Book Pro 14 2026 as a quirk (rev2) Patchwork
2026-04-20 15:52 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-20 18:30 ` ✓ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b626e3431b1e099c13b729be5fd8d89a962a1da.camel@intel.com \
--to=jouni.hogander@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).