From: "Gupta, Anshuman" <anshuman.gupta@intel.com>
To: "Tauro, Riana" <riana.tauro@intel.com>,
"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>
Cc: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
"aravind.iddamsetty@linux.intel.com"
<aravind.iddamsetty@linux.intel.com>,
"Nilawar, Badal" <badal.nilawar@intel.com>,
"Jadav, Raag" <raag.jadav@intel.com>,
"Koppuravuri, Ravi Kishore" <ravi.kishore.koppuravuri@intel.com>,
"Koujalagi, Mallesh" <mallesh.koujalagi@intel.com>,
"Purkait, Soham" <soham.purkait@intel.com>
Subject: RE: [PATCH v4 13/13] drm/xe/xe_pci_error: Process errors in mmio_enabled
Date: Thu, 30 Apr 2026 11:15:05 +0000 [thread overview]
Message-ID: <BN9PR11MB5242107CE3AA04F2B27AC75895352@BN9PR11MB5242.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20260417085812.4013309-28-riana.tauro@intel.com>
> -----Original Message-----
> From: Tauro, Riana <riana.tauro@intel.com>
> Sent: Friday, April 17, 2026 2:28 PM
> To: intel-xe@lists.freedesktop.org
> Cc: Tauro, Riana <riana.tauro@intel.com>; Gupta, Anshuman
> <anshuman.gupta@intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>;
> aravind.iddamsetty@linux.intel.com; Nilawar, Badal
> <badal.nilawar@intel.com>; Jadav, Raag <raag.jadav@intel.com>;
> Koppuravuri, Ravi Kishore <ravi.kishore.koppuravuri@intel.com>; Koujalagi,
> Mallesh <mallesh.koujalagi@intel.com>; Purkait, Soham
> <soham.purkait@intel.com>
> Subject: [PATCH v4 13/13] drm/xe/xe_pci_error: Process errors in
> mmio_enabled
>
> Query system controller when any non fatal error occurs to check the type of
> the error, contain and recover.
>
> The system controller is queried in the mmio_enabled callback.
>
> Signed-off-by: Riana Tauro <riana.tauro@intel.com>
> ---
> v2: use ras recovery enum (Raag)
>
> v3: add comment for mapping
> use const (Mallesh)
> ---
> drivers/gpu/drm/xe/xe_pci_error.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_pci_error.c
> b/drivers/gpu/drm/xe/xe_pci_error.c
> index 7d80bc2a6954..b7acf6778603 100644
> --- a/drivers/gpu/drm/xe/xe_pci_error.c
> +++ b/drivers/gpu/drm/xe/xe_pci_error.c
> @@ -9,6 +9,7 @@
> #include "xe_device.h"
> #include "xe_gt.h"
> #include "xe_pci.h"
> +#include "xe_ras.h"
> #include "xe_survivability_mode.h"
> #include "xe_uc.h"
>
> @@ -34,6 +35,13 @@ static void xe_pci_error_handling(struct pci_dev
> *pdev)
> pci_disable_device(pdev);
> }
>
> +/* Mapping of RAS recovery action to PCI error result */ static const
> +pci_ers_result_t ras_recovery_action_to_pci_result[] = {
> + [XE_RAS_RECOVERY_ACTION_RECOVERED] =
> PCI_ERS_RESULT_RECOVERED,
> + [XE_RAS_RECOVERY_ACTION_RESET] =
> PCI_ERS_RESULT_NEED_RESET,
> + [XE_RAS_RECOVERY_ACTION_DISCONNECT] =
> PCI_ERS_RESULT_DISCONNECT, };
> +
> static pci_ers_result_t xe_pci_error_detected(struct pci_dev *pdev,
> pci_channel_state_t state) {
> struct xe_device *xe = pdev_to_xe_device(pdev); @@ -59,9 +67,13
> @@ static pci_ers_result_t xe_pci_error_detected(struct pci_dev *pdev,
> pci_channel_
>
> static pci_ers_result_t xe_pci_error_mmio_enabled(struct pci_dev *pdev) {
> + struct xe_device *xe = pdev_to_xe_device(pdev);
> + enum xe_ras_recovery_action action;
> +
> dev_err(&pdev->dev, "Xe Pci error recovery: MMIO enabled\n");
> + action = xe_ras_process_errors(xe);
>
> - return PCI_ERS_RESULT_NEED_RESET;
> + return ras_recovery_action_to_pci_result[action];
Don't we need the array bound check for action ?
Above review comment assisted by AI Tools.
Thanks,
Anshuman
> }
>
> static pci_ers_result_t xe_pci_error_slot_reset(struct pci_dev *pdev)
> --
> 2.47.1
next prev parent reply other threads:[~2026-04-30 11:15 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 8:58 [PATCH v4 00/13] Introduce Xe Uncorrectable Error Handling Riana Tauro
2026-04-17 8:58 ` [PATCH v4 01/13] drm/xe/xe_survivability: Decouple survivability info from boot survivability Riana Tauro
2026-04-17 8:58 ` [PATCH v4 02/13] drm/xe/xe_pci_error: Implement PCI error recovery callbacks Riana Tauro
2026-04-27 6:35 ` Raag Jadav
2026-05-06 13:59 ` Tauro, Riana
2026-04-17 8:58 ` [PATCH v4 03/13] drm/xe/xe_pci_error: Group all devres to release them on PCIe slot reset Riana Tauro
2026-04-17 8:58 ` [PATCH v4 04/13] drm/xe: Skip device access during PCI error recovery Riana Tauro
2026-04-30 12:58 ` Anshuman Gupta
2026-05-06 15:41 ` Tauro, Riana
2026-04-17 8:58 ` [PATCH v4 05/13] drm/xe/xe_ras: Initialize Uncorrectable AER Registers Riana Tauro
2026-04-27 7:56 ` Raag Jadav
2026-05-05 5:22 ` Tauro, Riana
2026-04-17 8:58 ` [PATCH v4 06/13] drm/xe/xe_ras: Add basic structures and commands for uncorrectable errors Riana Tauro
2026-04-17 17:38 ` Matt Roper
2026-04-17 21:25 ` Jadav, Raag
2026-04-17 21:32 ` Matt Roper
2026-04-20 5:34 ` Tauro, Riana
2026-04-20 7:49 ` Raag Jadav
2026-04-17 8:58 ` [PATCH v4 07/13] drm/xe/xe_ras: Add support for uncorrectable core-compute errors Riana Tauro
2026-04-27 8:24 ` Raag Jadav
2026-05-05 5:28 ` Tauro, Riana
2026-04-17 8:58 ` [PATCH v4 08/13] drm/xe/xe_ras: Handle uncorrectable SoC Internal errors Riana Tauro
2026-04-17 8:58 ` [PATCH v4 09/13] drm/xe/xe_ras: Handle uncorrectable device memory errors Riana Tauro
2026-04-21 6:08 ` Upadhyay, Tejas
2026-05-05 5:03 ` Tauro, Riana
2026-04-17 8:58 ` [PATCH v4 10/13] drm/xe/xe_ras: Add support to offline/decline a page Riana Tauro
2026-04-21 6:21 ` Upadhyay, Tejas
2026-05-05 5:16 ` Tauro, Riana
2026-04-17 8:58 ` [PATCH v4 11/13] drm/xe/xe_ras: Add support for page offline list and queue commands Riana Tauro
2026-04-21 6:19 ` Upadhyay, Tejas
2026-05-05 5:08 ` Tauro, Riana
2026-04-21 9:10 ` Upadhyay, Tejas
2026-05-05 5:17 ` Tauro, Riana
2026-04-17 8:58 ` [PATCH v4 12/13] drm/xe/xe_ras: Query errors from system controller on probe Riana Tauro
2026-04-28 11:46 ` Raag Jadav
2026-05-05 13:50 ` Tauro, Riana
2026-04-17 8:58 ` [PATCH v4 13/13] drm/xe/xe_pci_error: Process errors in mmio_enabled Riana Tauro
2026-04-28 11:39 ` Raag Jadav
2026-05-05 5:31 ` Tauro, Riana
2026-04-30 11:15 ` Gupta, Anshuman [this message]
2026-05-02 17:55 ` Raag Jadav
2026-04-20 13:33 ` ✗ CI.checkpatch: warning for Introduce Xe Uncorrectable Error Handling (rev4) Patchwork
2026-04-20 13:35 ` ✓ CI.KUnit: success " Patchwork
2026-04-20 14:42 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-20 17:14 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB5242107CE3AA04F2B27AC75895352@BN9PR11MB5242.namprd11.prod.outlook.com \
--to=anshuman.gupta@intel.com \
--cc=aravind.iddamsetty@linux.intel.com \
--cc=badal.nilawar@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=mallesh.koujalagi@intel.com \
--cc=raag.jadav@intel.com \
--cc=ravi.kishore.koppuravuri@intel.com \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=soham.purkait@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).