From: "Tian, Kevin" <kevin.tian@intel.com>
To: "zhaoguohan@kylinos.cn" <zhaoguohan@kylinos.cn>,
Alex Williamson <alex@shazbot.org>,
"Winiarski, Michal" <michal.winiarski@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>
Cc: "Jason Gunthorpe" <jgg@ziepe.ca>,
"Yishai Hadas" <yishaih@nvidia.com>,
"Shameer Kolothum" <skolothumtho@nvidia.com>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] vfio/xe: avoid duplicate reset in xe_vfio_pci_reset_done
Date: Thu, 7 May 2026 08:04:46 +0000 [thread overview]
Message-ID: <BN9PR11MB5276D424BE9BB733539B59BD8C3C2@BN9PR11MB5276.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20260427012128.117051-1-zhaoguohan@kylinos.cn>
> From: zhaoguohan@kylinos.cn <zhaoguohan@kylinos.cn>
> Sent: Monday, April 27, 2026 9:21 AM
>
> From: GuoHan Zhao <zhaoguohan@kylinos.cn>
>
> xe_vfio_pci_reset_done() sets deferred_reset and, when it manages to
> acquire state_mutex itself, hands the cleanup off to
> xe_vfio_pci_state_mutex_unlock().
>
> That helper already clears deferred_reset and runs xe_vfio_pci_reset()
> before dropping the mutex. Calling xe_vfio_pci_reset() again right
> afterwards repeats the reset handling unnecessarily.
>
> Fixes: 1f5556ec8b9e ("vfio/xe: Add device specific vfio_pci driver variant for
> Intel graphics")
> Signed-off-by: GuoHan Zhao <zhaoguohan@kylinos.cn>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
next prev parent reply other threads:[~2026-05-07 8:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 9:17 [PATCH] vfio/xe: avoid duplicate reset in xe_vfio_pci_reset_done zhaoguohan
2026-04-24 12:41 ` ✗ CI.checkpatch: warning for " Patchwork
2026-04-24 12:42 ` ✓ CI.KUnit: success " Patchwork
2026-04-24 14:05 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-24 15:26 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-04-24 16:47 ` [PATCH] " Alex Williamson
2026-04-27 1:21 ` [PATCH v2] " zhaoguohan
2026-05-07 8:04 ` Tian, Kevin [this message]
2026-05-20 17:22 ` Alex Williamson
2026-05-20 18:25 ` Michał Winiarski
2026-05-20 21:11 ` Alex Williamson
2026-04-27 16:02 ` ✓ CI.KUnit: success for vfio/xe: avoid duplicate reset in xe_vfio_pci_reset_done (rev2) Patchwork
2026-04-27 16:52 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-27 19:25 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB5276D424BE9BB733539B59BD8C3C2@BN9PR11MB5276.namprd11.prod.outlook.com \
--to=kevin.tian@intel.com \
--cc=alex@shazbot.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jgg@ziepe.ca \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.winiarski@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=skolothumtho@nvidia.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=yishaih@nvidia.com \
--cc=zhaoguohan@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).