From: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: <intel-xe@lists.freedesktop.org>, <matthew.brost@intel.com>,
<stuart.summers@intel.com>
Subject: Re: [PATCH v4 04/11] drm/xe/multi_queue: Refactor check for multi queue support for engine class
Date: Wed, 6 May 2026 17:28:32 -0700 [thread overview]
Message-ID: <afvcsCWeuyko0Iz9@nvishwa1-desk> (raw)
In-Reply-To: <20260506223500.3769614-17-umesh.nerlige.ramappa@intel.com>
On Wed, May 06, 2026 at 03:35:05PM -0700, Umesh Nerlige Ramappa wrote:
>xe exec queue code is using a check to see if a class of engines support
>multi queue. This check is also needed by other code, so move it to
>xe_gt and export it for others.
>
>Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>---
>v2: (Niranjana)
>- s/xe_gt_hwe_class_supports_multi_queue/xe_gt_supports_multi_queue/
>- Update comment for helper
>- Move helper to header and make it static inline
LGTM.
Reviewed-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
>---
> drivers/gpu/drm/xe/xe_exec_queue.c | 7 +------
> drivers/gpu/drm/xe/xe_gt.h | 15 +++++++++++++++
> 2 files changed, 16 insertions(+), 6 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_exec_queue.c b/drivers/gpu/drm/xe/xe_exec_queue.c
>index 071b8c41df43..62a75c8fe72f 100644
>--- a/drivers/gpu/drm/xe/xe_exec_queue.c
>+++ b/drivers/gpu/drm/xe/xe_exec_queue.c
>@@ -852,11 +852,6 @@ static int xe_exec_queue_group_init(struct xe_device *xe, struct xe_exec_queue *
> return 0;
> }
>
>-static inline bool xe_exec_queue_supports_multi_queue(struct xe_exec_queue *q)
>-{
>- return q->gt->info.multi_queue_engine_class_mask & BIT(q->class);
>-}
>-
> static int xe_exec_queue_group_validate(struct xe_device *xe, struct xe_exec_queue *q,
> u32 primary_id)
> {
>@@ -931,7 +926,7 @@ static void xe_exec_queue_group_delete(struct xe_device *xe, struct xe_exec_queu
> static int exec_queue_set_multi_group(struct xe_device *xe, struct xe_exec_queue *q,
> u64 value)
> {
>- if (XE_IOCTL_DBG(xe, !xe_exec_queue_supports_multi_queue(q)))
>+ if (XE_IOCTL_DBG(xe, !xe_gt_supports_multi_queue(q->gt, q->class)))
> return -ENODEV;
>
> if (XE_IOCTL_DBG(xe, !xe_device_uc_enabled(xe)))
>diff --git a/drivers/gpu/drm/xe/xe_gt.h b/drivers/gpu/drm/xe/xe_gt.h
>index de7e47763411..4150aa594f05 100644
>--- a/drivers/gpu/drm/xe/xe_gt.h
>+++ b/drivers/gpu/drm/xe/xe_gt.h
>@@ -155,4 +155,19 @@ static inline bool xe_gt_recovery_pending(struct xe_gt *gt)
> xe_gt_sriov_vf_recovery_pending(gt);
> }
>
>+/**
>+ * xe_gt_supports_multi_queue() - Check if gt supports multi queue for the
>+ * specified engine class.
>+ *
>+ * @gt: the GT object
>+ * @class: hwe class type
>+ *
>+ * Return: true if the hw engine class supports multi queue, else false
>+ */
>+static inline bool xe_gt_supports_multi_queue(const struct xe_gt *gt,
>+ enum xe_engine_class class)
>+{
>+ return gt->info.multi_queue_engine_class_mask & BIT(class);
>+}
>+
> #endif
>--
>2.51.0
>
next prev parent reply other threads:[~2026-05-07 0:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 22:35 [PATCH v4 00/11] Support run ticks for multi-queue use case Umesh Nerlige Ramappa
2026-05-06 22:35 ` [PATCH v4 01/11] drm/xe/lrc: Use 64 bit ctx timestamp in the LRC snapshot Umesh Nerlige Ramappa
2026-05-06 22:35 ` [PATCH v4 02/11] drm/xe: Add timestamp_ms to " Umesh Nerlige Ramappa
2026-05-06 22:35 ` [PATCH v4 03/11] drm/xe/lrc: Refactor xe_lrc_timestamp to simplify logic Umesh Nerlige Ramappa
2026-05-06 22:35 ` [PATCH v4 04/11] drm/xe/multi_queue: Refactor check for multi queue support for engine class Umesh Nerlige Ramappa
2026-05-07 0:28 ` Niranjana Vishwanathapura [this message]
2026-05-06 22:35 ` [PATCH v4 05/11] drm/xe/multi_queue: Store primary LRC and position info in LRC Umesh Nerlige Ramappa
2026-05-07 0:35 ` Niranjana Vishwanathapura
2026-05-07 1:39 ` Niranjana Vishwanathapura
2026-05-06 22:35 ` [PATCH v4 06/11] drm/xe/multi_queue: Add helpers to access CS QUEUE TIMESTAMP from lrc Umesh Nerlige Ramappa
2026-05-07 0:29 ` Niranjana Vishwanathapura
2026-05-06 22:35 ` [PATCH v4 07/11] drm/xe/lrc: Refactor out engine id to hwe conversion Umesh Nerlige Ramappa
2026-05-06 22:35 ` [PATCH v4 08/11] drm/xe/multi_queue: Capture queue run times for active queues Umesh Nerlige Ramappa
2026-05-06 22:35 ` [PATCH v4 09/11] drm/xe/multi_queue: Add trace event for the multi queue timestamp Umesh Nerlige Ramappa
2026-05-07 0:28 ` Niranjana Vishwanathapura
2026-05-06 22:35 ` [PATCH v4 10/11] drm/xe/multi_queue: Use QUEUE_TIMESTAMP as job timestamp for multi-queue Umesh Nerlige Ramappa
2026-05-06 22:35 ` [PATCH v4 11/11] drm/xe/multi_queue: Whitelist QUEUE_TIMESTAMP register Umesh Nerlige Ramappa
2026-05-06 22:41 ` ✗ CI.checkpatch: warning for Support run ticks for multi-queue use case (rev4) Patchwork
2026-05-06 22:42 ` ✓ CI.KUnit: success " Patchwork
2026-05-06 23:44 ` ✓ Xe.CI.BAT: " Patchwork
2026-05-07 0:44 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afvcsCWeuyko0Iz9@nvishwa1-desk \
--to=niranjana.vishwanathapura@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
--cc=stuart.summers@intel.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).