From: Jens Axboe <axboe@kernel.dk>
To: Fengnan Chang <changfengnan@bytedance.com>,
Sasha Levin <sashal@kernel.org>,
Diangang Li <lidiangang@bytedance.com>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
Max Kellermann <max.kellermann@ionos.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] io_uring/io-wq: fix `max_workers` breakage and `nr_workers` underflow
Date: Mon, 15 Sep 2025 13:06:09 -0600 [thread overview]
Message-ID: <175796316976.265356.16431775523856266594.b4-ty@kernel.dk> (raw)
In-Reply-To: <20250912000609.1429966-1-max.kellermann@ionos.com>
On Fri, 12 Sep 2025 02:06:09 +0200, Max Kellermann wrote:
> Commit 88e6c42e40de ("io_uring/io-wq: add check free worker before
> create new worker") reused the variable `do_create` for something
> else, abusing it for the free worker check.
>
> This caused the value to effectively always be `true` at the time
> `nr_workers < max_workers` was checked, but it should really be
> `false`. This means the `max_workers` setting was ignored, and worse:
> if the limit had already been reached, incrementing `nr_workers` was
> skipped even though another worker would be created.
>
> [...]
Applied, thanks!
[1/1] io_uring/io-wq: fix `max_workers` breakage and `nr_workers` underflow
(no commit info)
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2025-09-15 19:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 0:06 [PATCH] io_uring/io-wq: fix `max_workers` breakage and `nr_workers` underflow Max Kellermann
2025-09-12 1:21 ` [External] " Fengnan Chang
2025-09-15 19:06 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175796316976.265356.16431775523856266594.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=changfengnan@bytedance.com \
--cc=io-uring@vger.kernel.org \
--cc=lidiangang@bytedance.com \
--cc=linux-kernel@vger.kernel.org \
--cc=max.kellermann@ionos.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).