From: Jens Axboe <axboe@kernel.dk>
To: io-uring@vger.kernel.org
Subject: [PATCHSET v2 0/4] Add support for batched min timeout
Date: Thu, 15 Feb 2024 09:06:55 -0700 [thread overview]
Message-ID: <20240215161002.3044270-1-axboe@kernel.dk> (raw)
Hi,
Normal CQE waiting is generally either done with a timeout, or without
one. Outside of the timeout, the other key parameter is how many events
to wait for. If we ask for N events and we get that within the timeout,
then we return successfully. If we do not, then we return with -ETIME
and the application can then check how many CQEs are actually available,
if any.
This works fine, but we're increasingly using smaller timeouts in
applications for targeted batch waiting. Eg "give me N requests in T
usec". If the application has other things do do every T usec, this
works fine. But if it's an event loop that wants to process completions
to make progress, it's pointless to return after T usec if there's
nothing to do. The application can't really make T bigger reliably, as
this may be the target it has to meet at busier times of the day.
This patchset adds support for min timeout waiting, which adds a third
parameter to how waits are done. The N and T timeout remain, but we add
a min_timeout option, M. The batch is now defined by N and M. The
application can now say "give me N requests in M usec, but if none have
arrived, just sleep until T has passed". This allows for using a sane
N+M, while avoid waking and returning all the time if nothing happens.
The semantics are as follows:
- If M expires and no events are available, keep waiting until T has
expired. This is identical to using N+T without setting M at all,
except if an event arrives after M has expired, we return immediately.
- If M expires and events are available, return those even if it's
less than N.
- If N events arrive before M expires, return those events. This is
identical to T == M, and M not being set.
There's a liburing branch with test cases here:
https://git.kernel.dk/cgit/liburing/log/?h=min-wait
and the patches are on top of the current for-6.9/io_uring branch. They
can also be viewed here:
https://git.kernel.dk/cgit/linux/log/?h=io_uring-min-wait
include/uapi/linux/io_uring.h | 3 +-
io_uring/io_uring.c | 156 ++++++++++++++++++++++++++++------
io_uring/io_uring.h | 4 +
3 files changed, 134 insertions(+), 29 deletions(-)
Changes since v1:
- Fix issue with both min_wait and timeout, and transitioning to the long
timeout. We'd add the current time potentially more than once, causing
much longer waits than what was asked for. Test case has been added for
that as well.
--
Jens Axboe
next reply other threads:[~2024-02-15 16:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 16:06 Jens Axboe [this message]
2024-02-15 16:06 ` [PATCH 1/4] io_uring: move schedule wait logic into helper Jens Axboe
2024-02-15 16:06 ` [PATCH 2/4] io_uring: implement our own schedule timeout handling Jens Axboe
2024-02-15 16:06 ` [PATCH 3/4] io_uring: add support for batch wait timeout Jens Axboe
2024-02-15 16:06 ` [PATCH 4/4] io_uring: wire up min batch wake timeout Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240215161002.3044270-1-axboe@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).