From: Denis Kenzior <denkenz@gmail.com>
To: James Prestwood <prestwoj@gmail.com>, iwd@lists.linux.dev
Subject: Re: [PATCH 1/4] unit: add to test-dpp to expose ASN1 point conversion bug
Date: Wed, 11 Oct 2023 10:24:07 -0500 [thread overview]
Message-ID: <00639fc2-662c-4641-89c7-7696d88b610b@gmail.com> (raw)
In-Reply-To: <20231010135704.198723-1-prestwoj@gmail.com>
Hi James,
On 10/10/23 08:57, James Prestwood wrote:
> Add a test to show the incorrect ASN1 conversion to and from points.
> This was due to the check if Y is odd/even being inverted which
> incorrectly prefixes the X coordinate with the wrong byte.
>
> The test itself was not fully correct because it was using compliant
> points rather than full points, and the spec contains the entire
> Y coordinate so the full point should be used.
>
> This patch also adds ASN1 conversions to validate that
> dpp_point_from_asn1 and dpp_point_to_asn1 work properly.
> ---
> unit/test-dpp.c | 44 +++++++++++++++++++++++++++++++-------------
> 1 file changed, 31 insertions(+), 13 deletions(-)
>
All applied, thanks.
Regards,
-Denis
prev parent reply other threads:[~2023-10-11 15:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 13:57 [PATCH 1/4] unit: add to test-dpp to expose ASN1 point conversion bug James Prestwood
2023-10-10 13:57 ` [PATCH 2/4] dpp-util: fix incorrect ASN1 compressed public key encoding James Prestwood
2023-10-10 13:57 ` [PATCH 3/4] eap-pwd: fix usage of compressed points (after ELL is fixed) James Prestwood
2023-10-10 13:57 ` [PATCH 4/4] sae: " James Prestwood
2023-10-11 15:24 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00639fc2-662c-4641-89c7-7696d88b610b@gmail.com \
--to=denkenz@gmail.com \
--cc=iwd@lists.linux.dev \
--cc=prestwoj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).