From: James Prestwood <prestwoj@gmail.com>
To: Denis Kenzior <denkenz@gmail.com>, iwd@lists.linux.dev
Subject: Re: [PATCH v2 1/4] knownnetworks: network: support updating known network settings
Date: Tue, 19 Dec 2023 09:49:35 -0800 [thread overview]
Message-ID: <2b3f455d-b265-471d-85eb-65202dcaf84d@gmail.com> (raw)
In-Reply-To: <0072dc90-2e28-4f12-9980-b32a693ef8a3@gmail.com>
On 12/19/23 9:46 AM, Denis Kenzior wrote:
> Hi James,
>
>>>
>>> Okay, then this patch in particular is not needed?
>>
>> Its at least partially needed, if a known network already exists
>> prior to DPP and its overwritten there is no callback. So we may not
>> need to actually touch network->settings at all as I thought. Just
>> emit an UPDATED event when the
>
> Okay, then just do that.
>
>> profile changes. DPP can then call network_autoconnect and the
>> settings _should_ be re-loaded unless I'm forgetting some instance
>> where network->settings can persist, but I don't think it can.
>
> network->settings is only created/opened when a connection is attempted.
Yeah, I think what caused most of my confusion was because DPP was using
network_set_passphrase/psk which will create an empty settings object if
the load fails (i.e. no profile). This then prevented
network_autoconnect() from opening the settings (since it thought they
already existed). So now the DPP change just syncs the profile and
doesn't touch the network object which lets network_autoconnect() deal
with loading, as it should.
>
> Regards,
> -Denis
prev parent reply other threads:[~2023-12-19 17:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 14:12 [PATCH v2 1/4] knownnetworks: network: support updating known network settings James Prestwood
2023-12-18 14:12 ` [PATCH v2 2/4] dpp: fix extra settings not being used when connecting James Prestwood
2023-12-18 14:12 ` [PATCH v2 3/4] auto-t: add DPP tests to check extra settings are applied James Prestwood
2023-12-18 14:12 ` [PATCH v2 4/4] auto-t: increase RAM when running with valgrind (UML) James Prestwood
2023-12-19 4:31 ` [PATCH v2 1/4] knownnetworks: network: support updating known network settings Denis Kenzior
2023-12-19 12:57 ` James Prestwood
2023-12-19 16:31 ` Denis Kenzior
2023-12-19 16:53 ` James Prestwood
2023-12-19 17:46 ` Denis Kenzior
2023-12-19 17:49 ` James Prestwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b3f455d-b265-471d-85eb-65202dcaf84d@gmail.com \
--to=prestwoj@gmail.com \
--cc=denkenz@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).