From: James Prestwood <prestwoj@gmail.com>
To: KeithG <ys3al35l@gmail.com>
Cc: Denis Kenzior <denkenz@gmail.com>, iwd@lists.linux.dev
Subject: Re: NT/VHT errors filling log
Date: Tue, 16 Apr 2024 08:34:57 -0700 [thread overview]
Message-ID: <35726d4d-ac32-45f3-a56a-c91d956f8a53@gmail.com> (raw)
In-Reply-To: <CAG17S_PvKeP98kDwBEfAVJg7nRDH50HgsxYZ-YXD6wL6AnQN5A@mail.gmail.com>
Hi Keith,
On 4/16/24 7:16 AM, KeithG wrote:
> James,
>
> The messages have changed with the latest build.
> Apr 16 05:24:30 kitchenrune iwd[1490859]: invalid HE capabilities for
> ac:ec:85:ab:10:d4
> Apr 16 05:53:31 kitchenrune iwd[1490859]: invalid HE capabilities for
> d8:07:b6:8e:97:7b
> Apr 16 05:58:23 kitchenrune iwd[1490859]: invalid HE capabilities for
> d8:07:b6:8e:97:7b
> Apr 16 06:22:23 kitchenrune iwd[1490859]: invalid HE capabilities for
> d8:07:b6:8e:97:7b
> Apr 16 06:53:26 kitchenrune iwd[1490859]: invalid HE capabilities for
> d8:07:b6:8e:97:7b
> Apr 16 07:23:39 kitchenrune iwd[1490859]: invalid HE capabilities for
> d8:07:b6:8e:97:7b
> Apr 16 07:55:07 kitchenrune iwd[1490859]: invalid HE capabilities for
> d8:07:b6:8e:97:7b
> Apr 16 07:55:07 kitchenrune iwd[1490859]: invalid HE capabilities for
> ae:70:5d:05:9f:f2
> Apr 16 07:58:34 kitchenrune iwd[1490859]: invalid HE capabilities for
> d8:07:b6:8e:97:7b
> Apr 16 08:25:08 kitchenrune iwd[1490859]: invalid HE capabilities for
> d8:07:b6:8e:97:7b
> Apr 16 08:25:08 kitchenrune iwd[1490859]: invalid HE capabilities for
> 1c:93:7c:73:36:92
> Apr 16 08:25:08 kitchenrune iwd[1490859]: invalid HE capabilities for
> 06:93:7c:73:36:92
Yeah I see this on one AP around me depending on where I have my laptop.
I think this incorrect bit setting is likely common across a lot of APs,
maybe something within hostapd itself... Either way the warning here
isn't something you need to worry about, although I agree its an
"annoyance" now. The hard part is if we remove it then someone will come
along later and say "why isn't IWD estimating the HE data rate?" and
we'll have to waste time debugging again. At least with this its clear:
your AP is advertising an invalid HE capabilities IE.
Thinking out loud here, one option would be to potentially flag the
capability used and print it out with the scan results. Something like:
data_rate: 2402.0 (HE)
Then if someone complains their AP supports HE but IWD is using VHT we
can say its _most likely_ the invalid HE capabilities. But that isn't as
direct as the warning.
Another option would be to be less strict with the check (likely what
wpa_supplicant does) and just take the IE as valid even though it isn't
following the requirements of the spec... but we don't tend to do that
unless its having some negative effect on IWD functioning correctly. For
this, the data rate estimation is just not as high as it could be, which
generally isn't going to change much.
Maybe if others could chime in and see if they also notice these
warnings now.
Thanks,
James
>
> Periodic scanning info from today.
>
> I use connman to manage the networks and we have a php script to
> scrape the network information advertised by the SSIDs. The attached
> txt file may be interesting to see what my RPi sees.
>
> Keith
>
>
>
> On Mon, Apr 15, 2024 at 1:57 PM James Prestwood <prestwoj@gmail.com>
> wrote:
> >
> >
> > On 4/15/24 11:50 AM, Denis Kenzior wrote:
> > > Hi James,
> > >
> > > On 4/15/24 10:15, James Prestwood wrote:
> > >> Hi Keith,
> > >>
> > >> On 4/15/24 4:24 AM, James Prestwood wrote:
> > >>> Hi Keith,
> > >>>
> > >>> On 4/12/24 10:41 AM, KeithG wrote:
> > >>>> Group,
> > >>>>
> > >>>> This is on a Pi5. this is with the 'current from git' build of iwd.
> > >>>> iwd-git/now 2.17.r0.g468cecdb-1
> > >>>> These are new errors which are showing up in the log and recur
> a lot:
> > >>>> Apr 12 12:14:17 pi5 iwd[1537]: error parsing HT capabilities
> > >>>> Apr 12 12:14:17 pi5 iwd[1537]: error parsing non-HT rates
> > >>>> Apr 12 12:14:17 pi5 iwd[1537]: error parsing VHT capabilities
> > >>>> Apr 12 12:14:17 pi5 iwd[1537]: error parsing HT capabilities
> > >>>> Apr 12 12:14:17 pi5 iwd[1537]: error parsing non-HT rates
> > >>>
> > >>> I added these recently as well as a small modification to improve
> > >>> fallback behavior for calculating the data rate. This isn't coming
> > >>> from the driver, but the scan results. Apparently APs sending
> > >>> invalid IEs is more widespread than I thought. I'll need to change
> > >>> this to instead maybe a single warning, or maybe hidden behind an
> > >>> env var.
> > >>
> > >> I sent some patches to the list which should help. You may still get
> > >> a warning for HE capabilities though, if APs are advertising the
> > >> malformed IE.
> > >
> > > Can we find out what is causing the errors? Is it the low RSSI?
> > >
> > > I rather we added a L_WARN_ONCE or L_WARN_THROTTLED or something
> > > instead of turning them off.
> >
> > Most likely low RSSI because I didn't handle -ENETUNREACH, so it treated
> > it as an error rather than silently dropping down to the next
> capability.
> >
> > >
> > > Regards,
> > > -Denis
prev parent reply other threads:[~2024-04-16 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 17:41 NT/VHT errors filling log KeithG
2024-04-15 11:24 ` James Prestwood
2024-04-15 15:15 ` James Prestwood
2024-04-15 18:50 ` Denis Kenzior
2024-04-15 18:57 ` James Prestwood
2024-04-16 14:16 ` KeithG
2024-04-16 15:34 ` James Prestwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35726d4d-ac32-45f3-a56a-c91d956f8a53@gmail.com \
--to=prestwoj@gmail.com \
--cc=denkenz@gmail.com \
--cc=iwd@lists.linux.dev \
--cc=ys3al35l@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).