From: Denis Kenzior <denkenz@gmail.com>
To: James Prestwood <prestwoj@gmail.com>, iwd@lists.linux.dev
Subject: Re: [PATCH] station: fix crash when deauth comes before FT work completes
Date: Mon, 27 Nov 2023 09:24:51 -0600 [thread overview]
Message-ID: <41e2fc45-adaa-442c-a912-5e46096ab14e@gmail.com> (raw)
In-Reply-To: <20231127124947.273760-1-prestwoj@gmail.com>
Hi James,
On 11/27/23 06:49, James Prestwood wrote:
> If the FT-Authenticate frame has been sent then a deauth is received
> the work item for sending the FT-Associate frame is never canceled.
> When this runs station->connected_network is NULL which causes a
> crash:
>
> src/station.c:station_try_next_transition() 7, target xx:xx:xx:xx:xx:xx
> src/wiphy.c:wiphy_radio_work_insert() Inserting work item 5843
> src/wiphy.c:wiphy_radio_work_insert() Inserting work item 5844
> src/wiphy.c:wiphy_radio_work_done() Work item 5842 done
> src/wiphy.c:wiphy_radio_work_next() Starting work item 5843
> src/netdev.c:netdev_mlme_notify() MLME notification Remain on Channel(55)
> src/ft.c:ft_send_authenticate()
> src/netdev.c:netdev_mlme_notify() MLME notification Frame TX Status(60)
> src/netdev.c:netdev_link_notify() event 16 on ifindex 7
> src/netdev.c:netdev_mlme_notify() MLME notification Del Station(20)
> src/netdev.c:netdev_mlme_notify() MLME notification Deauthenticate(39)
> src/netdev.c:netdev_deauthenticate_event()
> src/netdev.c:netdev_mlme_notify() MLME notification Disconnect(48)
> src/netdev.c:netdev_disconnect_event()
> Received Deauthentication event, reason: 7, from_ap: true
> src/station.c:station_disconnect_event() 7
> src/station.c:station_disassociated() 7
> src/station.c:station_reset_connection_state() 7
> src/station.c:station_roam_state_clear() 7
> src/netconfig.c:netconfig_event_handler() l_netconfig event 2
> src/netconfig-commit.c:netconfig_commit_print_addrs() removing address: yyy.yyy.yyy.yyy
> src/resolve.c:resolve_systemd_revert() ifindex: 7
> [DHCPv4] l_dhcp_client_stop:1264 Entering state: DHCP_STATE_INIT
> src/station.c:station_enter_state() Old State: connected, new state: disconnected
> src/station.c:station_enter_state() Old State: disconnected, new state: autoconnect_quick
> src/wiphy.c:wiphy_radio_work_insert() Inserting work item 5845
> src/netdev.c:netdev_mlme_notify() MLME notification Cancel Remain on Channel(56)
> src/wiphy.c:wiphy_radio_work_done() Work item 5843 done
> src/wiphy.c:wiphy_radio_work_next() Starting work item 5844
>
> "Program terminated with signal SIGSEGV, Segmentation fault.",
> "#0 0x0000565359ee3f54 in network_bss_find_by_addr ()",
> "#0 0x0000565359ee3f54 in network_bss_find_by_addr ()",
> "#1 0x0000565359ec9d23 in station_ft_work_ready ()",
> "#2 0x0000565359ec0af0 in wiphy_radio_work_next ()",
> "#3 0x0000565359f20080 in offchannel_mlme_notify ()",
> "#4 0x0000565359f4416b in received_data ()",
> "#5 0x0000565359f40d90 in io_callback ()",
> "#6 0x0000565359f3ff4d in l_main_iterate ()",
> "#7 0x0000565359f4001c in l_main_run ()",
> "#8 0x0000565359f40240 in l_main_run_with_signal ()",
> "#9 0x0000565359eb3888 in main ()"
> ---
> src/station.c | 3 +++
> 1 file changed, 3 insertions(+)
>
Applied, thanks.
Regards,
-Denis
prev parent reply other threads:[~2023-11-27 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 12:49 [PATCH] station: fix crash when deauth comes before FT work completes James Prestwood
2023-11-27 15:24 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41e2fc45-adaa-442c-a912-5e46096ab14e@gmail.com \
--to=denkenz@gmail.com \
--cc=iwd@lists.linux.dev \
--cc=prestwoj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).