From: James Prestwood <prestwoj@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: iwd@lists.linux.dev
Subject: Re: [PATCH] build: install iwd-decrypt-profile
Date: Fri, 20 Oct 2023 08:49:50 -0700 [thread overview]
Message-ID: <569b7682-e334-4f71-85a6-e49fc8934952@gmail.com> (raw)
In-Reply-To: <F6D1FD48-E7AC-404B-936A-E4D5E3519FA2@holtmann.org>
Hi Marcel,
On 10/4/23 6:07 AM, Marcel Holtmann wrote:
> Hi James,
>
>> If profile encryption is enabled its not out of the question that
>> somebody might need to decrypt it. This isn't a problem building
>> from source but IWD as a package likely won't include the decrypt
>> tool unless its specifically copied out. Add iwd-decrypt-profile
>> to the list of installed programs like iwctl, iwmon, etc
>>
>> This also fixes a minor bug in Makefile.am which was building both
>> iwd-profile-decrypt and probe-req if DAEMON was true. This should
>> be TOOLS.
>> ---
>> Makefile.am | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/Makefile.am b/Makefile.am
>> index 2e962153..ebabcf1c 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -378,8 +378,9 @@ man_MANS += wired/ead.8
>> endif
>> endif
>>
>> -if DAEMON
>> -noinst_PROGRAMS += tools/probe-req tools/iwd-decrypt-profile
>> +if TOOLS
>> +noinst_PROGRAMS += tools/probe-req
>> +bin_PROGRAMS += tools/iwd-decrypt-profile
>>
>> tools_probe_req_SOURCES = tools/probe-req.c src/mpdu.h src/mpdu.c \
>> src/ie.h src/ie.c \
>
> I really prefer not installing that tool. If someone shoots themselves in the foot and need to recover, they can install it from the source. In addition, I do not want distributions cluster packages with random tools. That is going to get messy. If we ever think such a recover is needed, then it be better suited to be included in iwctl.
>
> I moved both tools in DAEMON since once you disable iwd binary, none of them should be build either.
This is fine, but it means --enable-tools has no function, just FYI.
If adding to iwctl is acceptable then I can go that route. This is a
tool we need as far as debugging and potential recovery goes so I'd like
it to be installed. I could also just keep this patch applied but I'd
prefer upstreaming what I can.
I just wonder about the semantics using iwctl in this way. It doesn't
seem like it would fit very well.
Thanks,
James
>
> Regards
>
> Marcel
>
next prev parent reply other threads:[~2023-10-20 15:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 19:24 [PATCH] build: install iwd-decrypt-profile James Prestwood
2023-10-04 13:07 ` Marcel Holtmann
2023-10-20 15:49 ` James Prestwood [this message]
2023-10-20 12:52 ` James Prestwood
2023-10-20 15:19 ` Denis Kenzior
2023-10-20 15:25 ` James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569b7682-e334-4f71-85a6-e49fc8934952@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).