From: Denis Kenzior <denkenz@gmail.com>
To: jeremy.whiting@collabora.com, iwd@lists.linux.dev
Cc: ed.smith@collabora.com, alvaro.soliverez@collabora.com
Subject: Re: [PATCH v4] Register EAPOL frame listeners earlier
Date: Thu, 28 Mar 2024 17:41:50 -0500 [thread overview]
Message-ID: <b126d8fc-65b1-48b0-823e-7973b4140105@gmail.com> (raw)
In-Reply-To: <20240328223931.814213-1-jeremy.whiting@collabora.com>
Hi Jeremy/Ed,
On 3/28/24 17:39, jeremy.whiting@collabora.com wrote:
> From: Ed Smith <ed.smith@collabora.com>
>
> If we register the main EAPOL frame listener as late as the associate
> event, it may not observe ptk_1_of_4. This defeats handling for early
> messages in eapol_rx_packet, which only sees messages once it has been
> registered.
>
> If we move registration to the authenticate event, then the EAPOL
> frame listeners should observe all messages, without any possible
> races. Note that the messages are not actually processed until
> eapol_start() is called, and we haven't moved that call site. All
> that's changing here is how early EAPOL messages can be observed.
> ---
> src/netdev.c | 21 +++++++++++++++++----
> 1 file changed, 17 insertions(+), 4 deletions(-)
>
Applied, thanks.
Regards,
-Denis
prev parent reply other threads:[~2024-03-28 22:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 22:39 [PATCH v4] Register EAPOL frame listeners earlier jeremy.whiting
2024-03-28 22:41 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b126d8fc-65b1-48b0-823e-7973b4140105@gmail.com \
--to=denkenz@gmail.com \
--cc=alvaro.soliverez@collabora.com \
--cc=ed.smith@collabora.com \
--cc=iwd@lists.linux.dev \
--cc=jeremy.whiting@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).