From: Denis Kenzior <denkenz@gmail.com>
To: Andreas Radke <andyrtr@archlinux.org>, iwd@lists.linux.dev
Subject: Re: test failure with LTO still present
Date: Mon, 22 Jan 2024 09:10:03 -0600 [thread overview]
Message-ID: <ca3f8c89-d11f-4017-b76e-eb30101d2e78@gmail.com> (raw)
In-Reply-To: <20240122104541.74f1a697@workstation64.local>
Hi Andreas,
On 1/22/24 03:45, Andreas Radke wrote:
> When building the Arch Linux package with lto enabled we are still
> getting this old failure here:
>
> PASS: unit/test-eap-sim
> CC unit/test-sae.o
> CCLD unit/test-sae
> /usr/bin/ld: /tmp/cc7oo1S0.ltrans0.ltrans.o: in function `sae_choose_next_group':
> /usr/src/debug/iwd/iwd-2.13/src/sae.c:153:(.text+0xb9b): undefined reference to `__wrap_l_ecc_supported_ike_groups'
> /usr/bin/ld: /tmp/cc7oo1S0.ltrans0.ltrans.o: in function `sae_rx_authenticate':
> /usr/src/debug/iwd/iwd-2.13/src/sae.c:197:(.text+0x2e21): undefined reference to `__wrap_l_ecc_supported_ike_groups'
> /usr/bin/ld: /tmp/cc7oo1S0.ltrans0.ltrans.o: in function `handshake_state_free':
> /usr/src/debug/iwd/iwd-2.13/src/handshake.c:49:(.text+0x3455): undefined reference to `__wrap_l_ecc_supported_ike_groups'
> /usr/bin/ld: /tmp/cc7oo1S0.ltrans0.ltrans.o:/usr/src/debug/iwd/iwd-2.13/src/handshake.c:49:(.text+0x3491): undefined reference to `__wrap_l_ecc_supported_ike_groups'
> collect2: error: ld returned 1 exit status
> make[3]: *** [Makefile:2279: unit/test-sae] Error 1
> make[2]: *** [Makefile:3016: check-TESTS] Error 2
> make[1]: *** [Makefile:3366: check-am] Error 2
> make: *** [Makefile:3368: check] Error 2
>
>
> This seems to be the same error reported to the iwd list here:
> https://lore.kernel.org/iwd/c4b50311-84ab-236a-e3cd-49371a9d7eb4@gmail.com/T/#mbe4525effbbcde51a291ece026da1a25ecbfcbc4
>
> and also Debian and Gentoo seems to be affected as well:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1015432
> https://bugs.gentoo.org/877755
>
> Is there any way to solve this other than to disable lto?
>
We hack into and overload ell's l_ecc_supported_ike_groups() for the purposes of
this test. This solution is non-invasive to ell and works great on non-LTO
builds, but doesn't work with LTO. Short of introducing private methods into
ell for overriding default behavior, I'm not sure what the solution is.
[1] https://git.kernel.org/pub/scm/libs/ell/ell.git/tree/ell/ecc.c#n98
[2] https://git.kernel.org/pub/scm/network/wireless/iwd.git/tree/unit/test-sae.c#n41
Regards,
-Denis
prev parent reply other threads:[~2024-01-22 15:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 9:45 test failure with LTO still present Andreas Radke
2024-01-22 15:10 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca3f8c89-d11f-4017-b76e-eb30101d2e78@gmail.com \
--to=denkenz@gmail.com \
--cc=andyrtr@archlinux.org \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).